Summary: | Flesh out RenderLayer's ScrollableArea implementation a little more | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||
Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dglazkov, eric, gustavo.noronha, gustavo, jonlee, sam, simon.fraser, webkit.review.bot, xan.lopez | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2011-05-10 15:42:41 PDT
Created attachment 93033 [details]
Patch
Comment on attachment 93033 [details] Patch Attachment 93033 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8687102 Created attachment 93040 [details]
Patch
Comment on attachment 93040 [details] Patch Attachment 93040 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8684186 Comment on attachment 93040 [details] Patch Attachment 93040 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8685193 Comment on attachment 93040 [details] Patch Attachment 93040 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/8684225 Comment on attachment 93040 [details] Patch Attachment 93040 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/8688148 Another commit landed under this last patch, breaking it. Comment on attachment 93040 [details] Patch Attachment 93040 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/8691102 Comment on attachment 93040 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93040&action=review > Source/WebCore/platform/ScrollableArea.h:124 > + virtual IntRect visibleContentRect(bool /*includeScrollbars*/ = false) const { ASSERT_NOT_REACHED(); return IntRect(); } We generally prefer enums over bools (I know this isn't your code, but eventually we should fix it.) We should teach the cr-linux-ews not to cq- a patch when it can't be applied. Comment on attachment 93040 [details] Patch Attachment 93040 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/8691173 Created attachment 93138 [details]
Patch
|