Bug 60593

Summary: Flesh out RenderLayer's ScrollableArea implementation a little more
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, gustavo.noronha, gustavo, jonlee, sam, simon.fraser, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch darin: review+

Simon Fraser (smfr)
Reported 2011-05-10 15:42:41 PDT
RenderLayer needs to override a few more ScrollableArea methods.
Attachments
Patch (5.93 KB, patch)
2011-05-10 16:05 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (5.81 KB, patch)
2011-05-10 16:24 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (5.82 KB, patch)
2011-05-11 10:00 PDT, Simon Fraser (smfr) 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2011-05-10 16:05:23 PDT
Created attachment 93033 [details] Patch
Early Warning System Bot
Comment 2 2011-05-10 16:19:28 PDT
Comment on attachment 93033 [details] Patch Attachment 93033 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8687102
Simon Fraser (smfr)
Comment 3 2011-05-10 16:24:32 PDT
Created attachment 93040 [details] Patch
WebKit Review Bot
Comment 4 2011-05-10 17:33:55 PDT
Comment on attachment 93040 [details] Patch Attachment 93040 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8684186
WebKit Review Bot
Comment 5 2011-05-10 18:56:49 PDT
Comment on attachment 93040 [details] Patch Attachment 93040 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8685193
WebKit Review Bot
Comment 6 2011-05-10 18:59:57 PDT
Comment on attachment 93040 [details] Patch Attachment 93040 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/8684225
WebKit Review Bot
Comment 7 2011-05-10 19:27:36 PDT
Comment on attachment 93040 [details] Patch Attachment 93040 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/8688148
Simon Fraser (smfr)
Comment 8 2011-05-10 20:57:48 PDT
Another commit landed under this last patch, breaking it.
Gyuyoung Kim
Comment 9 2011-05-10 21:21:48 PDT
Comment on attachment 93040 [details] Patch Attachment 93040 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/8691102
Eric Seidel (no email)
Comment 10 2011-05-10 22:25:41 PDT
Comment on attachment 93040 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93040&action=review > Source/WebCore/platform/ScrollableArea.h:124 > + virtual IntRect visibleContentRect(bool /*includeScrollbars*/ = false) const { ASSERT_NOT_REACHED(); return IntRect(); } We generally prefer enums over bools (I know this isn't your code, but eventually we should fix it.)
Eric Seidel (no email)
Comment 11 2011-05-10 22:26:28 PDT
We should teach the cr-linux-ews not to cq- a patch when it can't be applied.
Collabora GTK+ EWS bot
Comment 12 2011-05-11 02:17:22 PDT
Comment on attachment 93040 [details] Patch Attachment 93040 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/8691173
Simon Fraser (smfr)
Comment 13 2011-05-11 10:00:17 PDT
Created attachment 93138 [details] Patch
Simon Fraser (smfr)
Comment 14 2011-05-11 13:55:42 PDT
http://trac.webkit.org/changeset/86262
Note You need to log in before you can comment on or make changes to this bug.