Bug 60582

Summary:

Crash switching overlay/non-overlay scrollbar preference still possible

Product:

WebKit

Reporter:

Beth Dakin <bdakin>

Component:

Layout and Rendering

Assignee:

Beth Dakin <bdakin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	darin: review+

Description Beth Dakin 2011-05-10 14:28:38 PDT

There are still some reports of crashing when switching the overlay/non-overlay scrollbar preference. We have not found a way to reproduce any of these crashes.

I have a fix that prevents any work from being done on pages that are in the page cache when the preference is switched.

<rdar://problem/9323983>

Comment 1 Beth Dakin 2011-05-10 15:13:06 PDT

Created attachment 93023 [details]
Patch

Comment 2 WebKit Review Bot 2011-05-10 15:15:28 PDT

Attachment 93023 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/page/FrameView.h:270:  The parameter name "active" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/mac/ScrollAnimatorMac.h:84:  The parameter name "active" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Beth Dakin 2011-05-10 15:18:01 PDT

Created attachment 93025 [details]
Patch

Comment 4 WebKit Review Bot 2011-05-10 15:20:09 PDT

Attachment 93025 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/mac/ScrollAnimatorMac.h:84:  The parameter name "active" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Beth Dakin 2011-05-10 15:28:39 PDT

Created attachment 93027 [details]
Patch

Comment 6 Beth Dakin 2011-05-10 15:38:14 PDT

Thanks Darin! Committed change with revision 86184.