| Summary: | EWS bots should be robust against test-webkitpy hangs | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||||||
| Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | abarth, evan, mihaip, tony | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 57724 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Eric Seidel (no email)
2011-05-10 14:03:59 PDT
Created attachment 93003 [details]
Patch
Created attachment 93005 [details]
updated changelog
The only problem with this patch as written is that it will remove all the gclient directories for Chromium. I'm not sure if that matters or not. It might slow down the chromium EWSes more than we want. I could add another --exclude line which ignores Source/WebKit/chromium Comment on attachment 93005 [details] updated changelog View in context: https://bugs.webkit.org/attachment.cgi?id=93005&action=review > Tools/EWSTools/start-queue.sh:61 > + git clean --force -x -d --exclude=WebKitBuild I used to try this, but it slams the EBS volumes too much. (In reply to comment #4) > (From update of attachment 93005 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=93005&action=review > > > Tools/EWSTools/start-queue.sh:61 > > + git clean --force -x -d --exclude=WebKitBuild > > I used to try this, but it slams the EBS volumes too much. What do you mean by that? Created attachment 93007 [details]
now ignoring chromium gclient content too
(In reply to comment #3) > The only problem with this patch as written is that it will remove all the gclient directories for Chromium. I'm not sure if that matters or not. It might slow down the chromium EWSes more than we want. I could add another --exclude line which ignores Source/WebKit/chromium Doesn't git clean ignore the directories in .gitignore, which includes the gclient pulled directories? git clean does, unless you pass -x. :) Comment on attachment 93007 [details] now ignoring chromium gclient content too View in context: https://bugs.webkit.org/attachment.cgi?id=93007&action=review > Tools/EWSTools/start-queue.sh:63 > + git clean --force -x -d --exclude=WebKitBuild --exclude=Source/WebKit/chromium We should just use find . -name "*.pyc" | xargs rm to start with. If we need to do mores we can revise. -f -x -d is too big a hammer. I think I tried to do too much in one patch. I'll post a patch which has no functional changes besides the watchdog. Created attachment 93053 [details]
Patch
Looks fine, but the changelog isn't right anymore. Committed r86213: <http://trac.webkit.org/changeset/86213> |