Bug 60575

Summary:

Rename Widget::pos()

Product:

WebKit

Reporter:

Levi Weintraub <leviw>

Component:

WebCore Misc.

Assignee:

Levi Weintraub <leviw>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, dglazkov, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Levi Weintraub

Reported 2011-05-10 13:36:35 PDT

pos is not a good name, position or location would be far better... My vote is for "location()"

Attachments
Patch (2.57 KB, patch) 2011-05-11 14:30 PDT, Levi Weintraub	no flags	Details Formatted Diff Diff
Patch (4.52 KB, patch) 2011-05-11 15:58 PDT, Levi Weintraub	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2011-05-10 13:42:56 PDT

location() seems to match what IntRect uses.

Levi Weintraub

Comment 2 2011-05-11 14:30:37 PDT

Created attachment 93187 [details] Patch

Eric Seidel (no email)

Comment 3 2011-05-11 14:31:25 PDT

Comment on attachment 93187 [details] Patch LGTM.

WebKit Review Bot

Comment 4 2011-05-11 15:36:03 PDT

Comment on attachment 93187 [details] Patch Attachment 93187 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8688475

Levi Weintraub

Comment 5 2011-05-11 15:36:41 PDT

I <3 EWS.

Levi Weintraub

Comment 6 2011-05-11 15:58:11 PDT

Created attachment 93203 [details] Patch

Eric Seidel (no email)

Comment 7 2011-05-11 16:01:14 PDT

Comment on attachment 93203 [details] Patch OK.

WebKit Commit Bot

Comment 8 2011-05-11 18:30:27 PDT

Comment on attachment 93203 [details] Patch Rejecting attachment 93203 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-a..." exit_code: 1 Last 500 characters of output: autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output: http://queues.webkit.org/results/8687523

Levi Weintraub

Comment 9 2011-05-11 19:17:32 PDT

Thanks for restarting it.

WebKit Commit Bot

Comment 10 2011-05-11 22:45:41 PDT

Comment on attachment 93203 [details] Patch Clearing flags on attachment: 93203 Committed r86312: <http://trac.webkit.org/changeset/86312>

WebKit Commit Bot

Comment 11 2011-05-11 22:45:47 PDT

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 12 2011-05-11 22:56:52 PDT

http://trac.webkit.org/changeset/86312 might have broken Chromium Win Release

Darin Adler

Comment 13 2011-05-12 09:19:43 PDT

Comment on attachment 93203 [details] Patch Given the function is used in only 6 places, I think we would have been better off removing it entirely. It seems unnecessary to have helper functions that return pieces of the frameRect.

Note You need to log in before you can comment on or make changes to this bug.