Bug 60548

Summary: [Chromium] Add rebaselines for video-layer-crash.
Product: WebKit Reporter: imasaki
Component: New BugsAssignee: imasaki
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, jianli, levin, scherkus, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

imasaki
Reported 2011-05-10 06:44:33 PDT
[Chromium] Add rebaselines for video-layer-crash.
Attachments
Patch (465.21 KB, patch)
2011-05-10 06:46 PDT, imasaki 		no flags
DetailsFormatted DiffDiff
Patch (465.24 KB, patch)
2011-05-10 10:34 PDT, imasaki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
imasaki
Comment 1 2011-05-10 06:46:51 PDT
Created attachment 92948 [details] Patch
David Levin
Comment 2 2011-05-10 09:51:49 PDT
Comment on attachment 92948 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92948&action=review > LayoutTests/ChangeLog:9 > + failing for a long time so rebaselines are necessary. We Sorry, this explanation doesn't make sense to me. There are a lot of tests that have been failing for a long time but we shouldn't just rebaseline them. Perhaps, you just meant to say that the image needs to be updated because it is incorrect (but the reason why this change happened isn't easily determined at present because the test has been broken for so long). Is the new baseline correct? (It looks like there isn't much difference from the old image so it probably is.)
imasaki
Comment 3 2011-05-10 10:34:53 PDT
Created attachment 92976 [details] Patch
WebKit Commit Bot
Comment 4 2011-05-10 11:04:46 PDT
Comment on attachment 92976 [details] Patch Clearing flags on attachment: 92976 Committed r86170: <http://trac.webkit.org/changeset/86170>
WebKit Commit Bot
Comment 5 2011-05-10 11:04:52 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2011-05-10 11:48:14 PDT
http://trac.webkit.org/changeset/86170 might have broken WinCairo Debug (Build)
Note You need to log in before you can comment on or make changes to this bug.