Summary: | [Chromium] Add rebaselines for video-layer-crash. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | imasaki | ||||||
Component: | New Bugs | Assignee: | imasaki | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, commit-queue, eric, jianli, levin, scherkus, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
imasaki
2011-05-10 06:44:33 PDT
Created attachment 92948 [details]
Patch
Comment on attachment 92948 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92948&action=review > LayoutTests/ChangeLog:9 > + failing for a long time so rebaselines are necessary. We Sorry, this explanation doesn't make sense to me. There are a lot of tests that have been failing for a long time but we shouldn't just rebaseline them. Perhaps, you just meant to say that the image needs to be updated because it is incorrect (but the reason why this change happened isn't easily determined at present because the test has been broken for so long). Is the new baseline correct? (It looks like there isn't much difference from the old image so it probably is.) Created attachment 92976 [details]
Patch
Comment on attachment 92976 [details] Patch Clearing flags on attachment: 92976 Committed r86170: <http://trac.webkit.org/changeset/86170> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/86170 might have broken WinCairo Debug (Build) |