Bug 60531

Summary: WebKit2: Cancelling full screen before animation completes leads to full screen window staying up.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: WebKit2Assignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.6   
Attachments:
Description Flags
Patch darin: review+

Description Jer Noble 2011-05-09 21:45:24 PDT 
WebKit2: Cancelling full screen before animation completes leads to full screen window staying up
Comment 1 Jer Noble 2011-05-09 21:46:34 PDT 
If the user cancels full screen mode before the enter full screen animation completes, Safari leaves the full screen window up containing the (non-full screen) page content.
Comment 2 Jer Noble 2011-05-09 21:51:30 PDT 
<rdar://problem/9411473>
Comment 3 Jer Noble 2011-05-09 21:52:32 PDT 
Created attachment 92915 [details]
Patch
Comment 4 Darin Adler 2011-05-10 08:51:15 PDT 
Comment on attachment 92915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92915&action=review

> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:-322
>      
> -    _isAnimating = NO;

Should remove this excess blank line too.
Comment 5 Jer Noble 2011-05-10 15:41:08 PDT 
(In reply to comment #4)
> (From update of attachment 92915 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=92915&action=review
> 
> > Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:-322
> >      
> > -    _isAnimating = NO;
> 
> Should remove this excess blank line too.

Will do.  Thanks!
Comment 6 Jer Noble 2011-05-10 15:43:37 PDT 
Committed r86186: <http://trac.webkit.org/changeset/86186>