Bug 60530

Summary:

Fix wincairo build broken due to gtest

Product:

WebKit

Reporter:

Dmitry Lomov <dslomov>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

bfulgham, dslomov, levin, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Attachments:

Description	Flags
Fixing build	none
Gor rid of bogus line terminator changes	none

Description Dmitry Lomov 2011-05-09 21:44:20 PDT

wincairo build has been broken due to addition of gtest

Comment 1 Dmitry Lomov 2011-05-09 21:53:28 PDT

Created attachment 92916 [details]
Fixing build

Comment 2 WebKit Review Bot 2011-05-09 21:56:29 PDT

Attachment 92916 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/ThirdParty/gtest/msvc..." exit_code: 1

Source/WebKit/win/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Dmitry Lomov 2011-05-09 22:09:55 PDT

Created attachment 92918 [details]
Gor rid of bogus line terminator changes

Comment 4 David Levin 2011-05-10 12:52:26 PDT

Comment on attachment 92918 [details]
Gor rid of bogus line terminator changes

Will be part of the bigger patch now (since the orig patch was rolled out).