Bug 60502

Summary: Enable strict PassOwnPtr on Chromium
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Adam Barth
Reported 2011-05-09 14:14:31 PDT
Enable strict PassOwnPtr on Chromium
Attachments
Patch (1.07 KB, patch)
2011-05-09 14:18 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (1.77 KB, patch)
2011-05-09 15:41 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (2.23 KB, patch)
2011-05-09 16:02 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (3.14 KB, patch)
2011-05-09 16:21 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (5.04 KB, patch)
2011-05-09 17:56 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (1.02 KB, patch)
2011-05-10 14:55 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-05-09 14:18:57 PDT
Created attachment 92849 [details] Patch
WebKit Review Bot
Comment 2 2011-05-09 14:59:44 PDT
Comment on attachment 92849 [details] Patch Attachment 92849 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8646697
Adam Barth
Comment 3 2011-05-09 15:41:43 PDT
Created attachment 92868 [details] Patch
David Levin
Comment 4 2011-05-09 15:46:50 PDT
If you meant to do r?, r=me on that patch as well.
Adam Barth
Comment 5 2011-05-09 15:56:58 PDT
(In reply to comment #4) > If you meant to do r?, r=me on that patch as well. I'm going to try iterating on this patch for a bit to see if it's hopeless to do without a real linux box.
Adam Barth
Comment 6 2011-05-09 16:02:01 PDT
Created attachment 92875 [details] Patch
Adam Barth
Comment 7 2011-05-09 16:21:26 PDT
Created attachment 92880 [details] Patch
Adam Barth
Comment 8 2011-05-09 17:56:23 PDT
Created attachment 92896 [details] Patch
Adam Barth
Comment 9 2011-05-10 00:50:54 PDT
Comment on attachment 92896 [details] Patch This is ready for commit, but it might cause trouble on landing. I'll need to watch the tree when this lands.
Adam Barth
Comment 10 2011-05-10 14:53:36 PDT
Committed r86182: <http://trac.webkit.org/changeset/86182>
Adam Barth
Comment 11 2011-05-10 14:55:19 PDT
Created attachment 93014 [details] Patch
Adam Barth
Comment 12 2011-05-10 22:21:23 PDT
Comment on attachment 93014 [details] Patch Clearing flags on attachment: 93014 Committed r86211: <http://trac.webkit.org/changeset/86211>
Adam Barth
Comment 13 2011-05-10 22:21:28 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 14 2011-05-10 22:55:12 PDT
http://trac.webkit.org/changeset/86211 might have broken Chromium Win Release
Note You need to log in before you can comment on or make changes to this bug.