Summary: | [Qt] DumpRenderTreeQt needs an implementation of unmarkText | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chang Shu <cshu> | ||||
Component: | Tools / Tests | Assignee: | Chang Shu <cshu> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, ossy | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Chang Shu
2011-05-09 12:54:37 PDT
Created attachment 92837 [details]
fix patch
Comment on attachment 92837 [details]
fix patch
Looks good. Are you going to use that confirmComposition for other tests? Because it is doing a lot more than unmarking text :-)
Maybe, I haven't realized it yet. :) Thanks for the review. (In reply to comment #2) > (From update of attachment 92837 [details]) > Looks good. Are you going to use that confirmComposition for other tests? Because it is doing a lot more than unmarking text :-) Comment on attachment 92837 [details] fix patch Clearing flags on attachment: 92837 Committed r86124: <http://trac.webkit.org/changeset/86124> All reviewed patches have been landed. Closing bug. Guys, you should have to run layout tests before commiting and/or watch the buildbots after commiting. Please respect the rules: http://www.webkit.org/coding/contributing.html "Once you have made your changes, you need to run the regression tests, which is done via the run-webkit-tests script. All tests must pass. Patches will not be landed in the tree if they break existing layout tests." I landed a fix: http://trac.webkit.org/changeset/86137 instead of you ... :S |