Bug 60462

Summary: [Qt] Support shadowed text in fast font path.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: ariya.hidayat, eric, hausmann, zimmermann
Priority: P2 Keywords: Performance, Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
kling: review-
Proposed patch v2 none

Andreas Kling
Reported 2011-05-09 04:29:31 PDT
Instead of defaulting to the Complex path for text with shadows, we should implement support for shadows in Font::drawGlyphs().
Attachments
Proposed patch (3.44 KB, patch)
2011-05-09 04:33 PDT, Andreas Kling 		kling: review-
DetailsFormatted DiffDiff
Proposed patch v2 (3.81 KB, patch)
2011-05-09 05:37 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2011-05-09 04:33:37 PDT
Created attachment 92779 [details] Proposed patch
Andreas Kling
Comment 2 2011-05-09 04:40:44 PDT
Comment on attachment 92779 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=92779&action=review > Source/WebCore/platform/graphics/qt/FontQt.cpp:369 > + // Since it will be blurred anyway, we don't care about render hints. Incorrect. We could be painting a non-blurred shadow here.
Andreas Kling
Comment 3 2011-05-09 05:37:19 PDT
Created attachment 92781 [details] Proposed patch v2 Add a separate code-path for solid shadows.
Kenneth Rohde Christiansen
Comment 4 2011-05-16 14:06:08 PDT
Comment on attachment 92781 [details] Proposed patch v2 Looks good, is this already falling under the current testing?
Andreas Kling
Comment 5 2011-05-17 04:37:00 PDT
Comment on attachment 92781 [details] Proposed patch v2 Clearing flags on attachment: 92781 Committed r86667: <http://trac.webkit.org/changeset/86667>
Andreas Kling
Comment 6 2011-05-17 04:37:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.