Bug 60462 - [Qt] Support shadowed text in fast font path.
Summary: [Qt] Support shadowed text in fast font path.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Keywords: Performance, Qt, QtTriaged
Depends on:
Reported: 2011-05-09 04:29 PDT by Andreas Kling
Modified: 2011-05-17 04:37 PDT (History)
4 users (show)

See Also:

Proposed patch (3.44 KB, patch)
2011-05-09 04:33 PDT, Andreas Kling
kling: review-
Details | Formatted Diff | Diff
Proposed patch v2 (3.81 KB, patch)
2011-05-09 05:37 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-05-09 04:29:31 PDT
Instead of defaulting to the Complex path for text with shadows, we should implement support for shadows in Font::drawGlyphs().
Comment 1 Andreas Kling 2011-05-09 04:33:37 PDT
Created attachment 92779 [details]
Proposed patch
Comment 2 Andreas Kling 2011-05-09 04:40:44 PDT
Comment on attachment 92779 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92779&action=review

> Source/WebCore/platform/graphics/qt/FontQt.cpp:369
> +            // Since it will be blurred anyway, we don't care about render hints.

Incorrect. We could be painting a non-blurred shadow here.
Comment 3 Andreas Kling 2011-05-09 05:37:19 PDT
Created attachment 92781 [details]
Proposed patch v2

Add a separate code-path for solid shadows.
Comment 4 Kenneth Rohde Christiansen 2011-05-16 14:06:08 PDT
Comment on attachment 92781 [details]
Proposed patch v2

Looks good, is this already falling under the current testing?
Comment 5 Andreas Kling 2011-05-17 04:37:00 PDT
Comment on attachment 92781 [details]
Proposed patch v2

Clearing flags on attachment: 92781

Committed r86667: <http://trac.webkit.org/changeset/86667>
Comment 6 Andreas Kling 2011-05-17 04:37:08 PDT
All reviewed patches have been landed.  Closing bug.