Summary: | Make Chromium build with strict PassOwnPtr | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, darin, dglazkov, eric, levin, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Adam Barth
2011-05-09 02:04:58 PDT
Created attachment 92772 [details]
Patch
Comment on attachment 92772 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92772&action=review > Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:380 > + // FIXME: Calling get here is dangerous! What if observer is freed? This FIXME seems less benign than the others. Is there a bug open? (In reply to comment #2) > (From update of attachment 92772 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=92772&action=review > > > Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:380 > > + // FIXME: Calling get here is dangerous! What if observer is freed? > > This FIXME seems less benign than the others. Is there a bug open? There isn't an open bug. I can create one, but having the FIXME in the code is probably more likely to get attention than having a bug on file... (Thanks for the review.) Comment on attachment 92772 [details] Patch Attachment 92772 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8646598 New failing tests: inspector/debugger/dom-breakpoints.html inspector/debugger/debugger-pause-in-eval-script.html inspector/debugger/debugger-proto-property.html inspector/debugger/event-listener-breakpoints.html inspector/debugger/debugger-no-nested-pause.html inspector/debugger/debugger-pause-on-debugger-statement.html inspector/debugger/debugger-pause-on-exception.html inspector/debugger/xhr-breakpoints.html inspector/debugger/debugger-step-over.html inspector/debugger/debugger-expand-scope.html inspector/console/console-api-on-call-frame.html inspector/debugger/debugger-eval-while-paused.html inspector/debugger/debugger-pause-on-breakpoint.html inspector/debugger/debugger-step-out.html inspector/debugger/live-edit.html inspector/debugger/debugger-eval-on-call-frame.html inspector/debugger/debugger-cyclic-ref.html inspector/debugger/debugger-step-in.html inspector/debugger/debugger-suspend-active-dom-objects.html Created attachment 92789 [details]
Archive of layout-test-results from ec2-cr-linux-01
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 92801 [details]
Patch for landing
Comment on attachment 92801 [details] Patch for landing Clearing flags on attachment: 92801 Committed r86067: <http://trac.webkit.org/changeset/86067> All reviewed patches have been landed. Closing bug. |