Bug 60457

Summary: [EFL] Added initialization/shutdown for ecore_file library
Product: WebKit Reporter: Tomasz Morawski <t.morawski>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, kenneth, lucas.de.marchi, rakuco, ryuan.choi, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
Patch
none
Fixed patch
none
Patch 3
none
Patch 4 none

Description Tomasz Morawski 2011-05-09 00:25:45 PDT
Added initialization and shuthown fo ecore_file library and replaced realpath function to ecore_file_realpath.
Comment 1 Tomasz Morawski 2011-05-09 00:26:58 PDT
Created attachment 92765 [details]
Patch
Comment 2 Lucas De Marchi 2011-05-09 04:47:52 PDT
Comment on attachment 92765 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92765&action=review

> Tools/ChangeLog:8
> +        Added initialization and shuthown fo ecore_file library and replaced

s/fo/for/

> Tools/EWebLauncher/main.c:802
> -    rpath = realpath(theme, NULL);
> +    rpath = ecore_file_realpath(theme);
>      if (!rpath)
>          return NULL;

ecore_file_realpath always allocate a string, even when realpath would return an error (exception: when there's an out of memory condition). In this case you need to check whether the returned string is empty.

> Tools/EWebLauncher/main.c:888
> +        return quit(EINA_FALSE, "ERROR: could not created tmp directory.\n");

s/created/create/
Comment 3 Tomasz Morawski 2011-05-09 05:53:16 PDT
Created attachment 92784 [details]
Fixed patch
Comment 4 Lucas De Marchi 2011-05-09 16:30:01 PDT
Comment on attachment 92784 [details]
Fixed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92784&action=review

> Tools/EWebLauncher/main.c:800
> -    rpath = realpath(theme, NULL);
> -    if (!rpath)
> -        return NULL;
> -
> -    if (stat(rpath, &st)) {
> +    rpath = ecore_file_realpath("/etc");

/etc ????

Why? Maybe you used as a test and let it here?
Comment 5 Tomasz Morawski 2011-05-09 22:55:28 PDT
Created attachment 92923 [details]
Patch 3
Comment 6 Raphael Kubo da Costa (:rakuco) 2011-05-10 14:06:46 PDT
It looks OK to me, informal r+ from my side.
Comment 7 Ryuan Choi 2011-05-10 21:50:17 PDT
rpath is not a parameter of ecore_file_realpath, right?

rpath = ecore_file_realpath(theme);
Comment 8 Tomasz Morawski 2011-05-11 01:05:11 PDT
Created attachment 93084 [details]
Patch 4
Comment 9 Lucas De Marchi 2011-05-11 05:25:21 PDT
(In reply to comment #7)
> rpath is not a parameter of ecore_file_realpath, right?

Right.


Tomasz, we can't apply every patch and test when reviewing. Please, test your changes to see if it really fixes the issue before uploading a new patch.

Now it looks good.
Comment 10 WebKit Commit Bot 2011-05-12 09:03:29 PDT
Comment on attachment 93084 [details]
Patch 4

Clearing flags on attachment: 93084

Committed r86349: <http://trac.webkit.org/changeset/86349>
Comment 11 WebKit Commit Bot 2011-05-12 09:03:35 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 WebKit Review Bot 2011-05-12 10:38:53 PDT
http://trac.webkit.org/changeset/86349 might have broken GTK Linux 32-bit Release