Bug 60438

Summary: Remove references to Tiger in scripts
Product: WebKit Reporter: Pratik Solanki <psolanki>
Component: Tools / TestsAssignee: Pratik Solanki <psolanki>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dbates, ddkilzer, eric, mrowe, psolanki, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Pratik Solanki
Reported 2011-05-07 10:15:37 PDT
We have a number of places in the Scripts directory where we use isTiger() to check for MacOSX Tiger. We can now remove those.
Attachments
Patch (9.86 KB, patch)
2011-05-07 10:19 PDT, Pratik Solanki 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pratik Solanki
Comment 1 2011-05-07 10:19:26 PDT
Created attachment 92693 [details] Patch
Eric Seidel (no email)
Comment 2 2011-05-07 12:08:43 PDT
Comment on attachment 92693 [details] Patch Yay! Thank you!
Pratik Solanki
Comment 3 2011-05-07 12:57:18 PDT
Committed r86007 :<http://trac.webkit.org/changeset/86007>
Simon Fraser (smfr)
Comment 4 2011-05-07 15:24:18 PDT
This broke a bunch of bots.
Daniel Bates
Comment 5 2011-05-07 16:10:52 PDT
(In reply to comment #4) > This broke a bunch of bots. Committed attempt to fix the build in changeset 86009 <http://trac.webkit.org/changeset/86009>; remove some more references to isTiger().
WebKit Review Bot
Comment 6 2011-05-07 16:10:59 PDT
http://trac.webkit.org/changeset/86007 might have broken Leopard Intel Debug (Tests)
Pratik Solanki
Comment 7 2011-05-07 19:57:56 PDT
Oops. Sorry. I didn't think old-run-webkit-tests was used. Thanks for fixing this Daniel.
Note You need to log in before you can comment on or make changes to this bug.