Bug 60438

Summary:

Remove references to Tiger in scripts

Product:

WebKit

Reporter:

Pratik Solanki <psolanki>

Component:

Tools / Tests

Assignee:

Pratik Solanki <psolanki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dbates, ddkilzer, eric, mrowe, psolanki, simon.fraser, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Description Pratik Solanki 2011-05-07 10:15:37 PDT

We have a number of places in the Scripts directory where we use isTiger() to check for MacOSX Tiger. We can now remove those.

Comment 1 Pratik Solanki 2011-05-07 10:19:26 PDT

Created attachment 92693 [details]
Patch

Comment 2 Eric Seidel (no email) 2011-05-07 12:08:43 PDT

Comment on attachment 92693 [details]
Patch

Yay!  Thank you!

Comment 3 Pratik Solanki 2011-05-07 12:57:18 PDT

Committed r86007 :<http://trac.webkit.org/changeset/86007>

Comment 4 Simon Fraser (smfr) 2011-05-07 15:24:18 PDT

This broke a bunch of bots.

Comment 5 Daniel Bates 2011-05-07 16:10:52 PDT

(In reply to comment #4)
> This broke a bunch of bots.

Committed attempt to fix the build in changeset 86009 <http://trac.webkit.org/changeset/86009>; remove some more references to isTiger().

Comment 6 WebKit Review Bot 2011-05-07 16:10:59 PDT

http://trac.webkit.org/changeset/86007 might have broken Leopard Intel Debug (Tests)

Comment 7 Pratik Solanki 2011-05-07 19:57:56 PDT

Oops. Sorry. I didn't think old-run-webkit-tests was used. Thanks for fixing this Daniel.