Bug 60388

Summary:

Fix some unnecessary includes in headers

Product:

WebKit

Reporter:

Tony Gentilcore <tonyg>

Component:

New Bugs

Assignee:

Tony Gentilcore <tonyg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, gustavo.noronha, gustavo, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

52451

Attachments:

Description	Flags
Patch	none
Patch	webkit.review.bot: commit-queue-
Patch	none
Patch	webkit.review.bot: commit-queue-
Patch	webkit.review.bot: commit-queue-
Patch	darin: review+

Tony Gentilcore

Reported 2011-05-06 11:14:05 PDT

Fix some unnecessary includes in headers

Attachments
Patch (28.16 KB, patch) 2011-05-06 11:16 PDT, Tony Gentilcore	no flags	Details Formatted Diff Diff
Patch (29.04 KB, patch) 2011-05-09 01:27 PDT, Tony Gentilcore	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Patch (29.52 KB, patch) 2011-05-09 01:56 PDT, Tony Gentilcore	no flags	Details Formatted Diff Diff
Patch (30.39 KB, patch) 2011-05-09 02:49 PDT, Tony Gentilcore	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Patch (31.90 KB, patch) 2011-05-09 04:13 PDT, Tony Gentilcore	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Patch (33.98 KB, patch) 2011-05-09 05:42 PDT, Tony Gentilcore	darin: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Tony Gentilcore

Comment 1 2011-05-06 11:16:03 PDT

Created attachment 92611 [details] Patch

WebKit Review Bot

Comment 2 2011-05-06 11:19:24 PDT

Attachment 92611 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/dom/TextEvent.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/css/RGBColor.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/dom/ExceptionBase.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 3 in 49 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 3 2011-05-06 11:29:45 PDT

Comment on attachment 92611 [details] Patch Attachment 92611 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8601058

Gyuyoung Kim

Comment 4 2011-05-06 12:41:27 PDT

Comment on attachment 92611 [details] Patch Attachment 92611 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/8615056

WebKit Review Bot

Comment 5 2011-05-06 12:48:16 PDT

Comment on attachment 92611 [details] Patch Attachment 92611 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8598065

WebKit Review Bot

Comment 6 2011-05-06 13:33:41 PDT

Comment on attachment 92611 [details] Patch Attachment 92611 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8617046

WebKit Review Bot

Comment 7 2011-05-06 13:40:48 PDT

Comment on attachment 92611 [details] Patch Attachment 92611 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/8620016

Collabora GTK+ EWS bot

Comment 8 2011-05-06 14:10:09 PDT

Comment on attachment 92611 [details] Patch Attachment 92611 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/8620025

WebKit Review Bot

Comment 9 2011-05-06 14:32:43 PDT

Comment on attachment 92611 [details] Patch Attachment 92611 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/8598097

Daniel Bates

Comment 10 2011-05-06 16:16:21 PDT

Comment on attachment 92611 [details] Patch Attachment 92611 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8608143

Tony Gentilcore

Comment 11 2011-05-07 04:06:20 PDT

Different flags and ports end up having different transitive deps that break. I'll work on making the bots happy. Please ignore this until then.

Tony Gentilcore

Comment 12 2011-05-09 01:27:30 PDT

Created attachment 92770 [details] Patch

WebKit Review Bot

Comment 13 2011-05-09 01:30:03 PDT

Attachment 92770 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/dom/TextEvent.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/css/RGBColor.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/dom/ExceptionBase.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 3 in 51 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 14 2011-05-09 01:41:17 PDT

Comment on attachment 92770 [details] Patch Attachment 92770 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8653516

Tony Gentilcore

Comment 15 2011-05-09 01:56:25 PDT

Created attachment 92771 [details] Patch

WebKit Review Bot

Comment 16 2011-05-09 02:01:22 PDT

Attachment 92771 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/dom/TextEvent.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/css/RGBColor.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/dom/ExceptionBase.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 3 in 52 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 17 2011-05-09 02:13:43 PDT

Comment on attachment 92771 [details] Patch Attachment 92771 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8660480

WebKit Review Bot

Comment 18 2011-05-09 02:31:39 PDT

Comment on attachment 92771 [details] Patch Attachment 92771 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8653523

Tony Gentilcore

Comment 19 2011-05-09 02:49:17 PDT

Created attachment 92775 [details] Patch

WebKit Review Bot

Comment 20 2011-05-09 02:51:48 PDT

Attachment 92775 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/dom/TextEvent.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/css/RGBColor.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/dom/ExceptionBase.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 3 in 54 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 21 2011-05-09 03:07:13 PDT

Comment on attachment 92775 [details] Patch Attachment 92775 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8646533

WebKit Review Bot

Comment 22 2011-05-09 03:29:16 PDT

Comment on attachment 92775 [details] Patch Attachment 92775 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8653538

WebKit Review Bot

Comment 23 2011-05-09 03:31:20 PDT

Comment on attachment 92770 [details] Patch Attachment 92770 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/8652504

Tony Gentilcore

Comment 24 2011-05-09 04:13:11 PDT

Created attachment 92778 [details] Patch

WebKit Review Bot

Comment 25 2011-05-09 04:15:31 PDT

Attachment 92778 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/dom/TextEvent.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/css/RGBColor.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/dom/ExceptionBase.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 3 in 57 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 26 2011-05-09 04:54:52 PDT

Comment on attachment 92778 [details] Patch Attachment 92778 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8646550

WebKit Review Bot

Comment 27 2011-05-09 05:18:40 PDT

Comment on attachment 92775 [details] Patch Attachment 92775 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/8652523

Tony Gentilcore

Comment 28 2011-05-09 05:42:26 PDT

Created attachment 92782 [details] Patch

WebKit Review Bot

Comment 29 2011-05-09 05:44:58 PDT

Attachment 92782 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/dom/TextEvent.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/css/RGBColor.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/dom/ExceptionBase.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 3 in 61 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 30 2011-05-09 06:37:14 PDT

Comment on attachment 92778 [details] Patch Attachment 92778 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/8648515

Darin Adler

Comment 31 2011-05-09 09:19:09 PDT

Comment on attachment 92782 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92782&action=review Looks good. Hard to judge a patch like this except by whether everything keeps compiling! > Source/WebCore/css/CSSFontFaceSrcValue.h:37 > #if ENABLE(SVG_FONTS) > -#include "SVGFontFaceElement.h" > +class SVGFontFaceElement; > #endif For the future, I’m not sure we need to put a forward-declaration of a class inside an #if. There is little or no harm to just declaring the name of a class unconditionally.

Tony Gentilcore

Comment 32 2011-05-09 09:26:34 PDT

(In reply to comment #31) > (From update of attachment 92782 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=92782&action=review > > Looks good. Hard to judge a patch like this except by whether everything keeps compiling! > > > Source/WebCore/css/CSSFontFaceSrcValue.h:37 > > #if ENABLE(SVG_FONTS) > > -#include "SVGFontFaceElement.h" > > +class SVGFontFaceElement; > > #endif > > For the future, I’m not sure we need to put a forward-declaration of a class inside an #if. There is little or no harm to just declaring the name of a class unconditionally. Thanks, I'll fix this and then land the patch in off-hours so I can fix any breakages for builds that don't have an EWS without bothering anyone.

Tony Gentilcore

Comment 33 2011-05-10 01:20:12 PDT

Committed r86135: <http://trac.webkit.org/changeset/86135>

Note You need to log in before you can comment on or make changes to this bug.