Summary: | Remove canvas usage of roundToDevicePixels | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matthew Delaney <mdelaney7> | ||||||||
Component: | Canvas | Assignee: | Matthew Delaney <mdelaney7> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | mdelaney7, simon.fraser | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Matthew Delaney
2011-05-05 19:26:23 PDT
Created attachment 92531 [details]
Patch
Comment on attachment 92531 [details]
Patch
Were all these calls to roundToDevicePixels() added at the same time? Have you looked at the history to check why each was added?
Created attachment 92810 [details]
Patch
Comment on attachment 92810 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92810&action=review > Source/WebCore/platform/graphics/cg/ImageCG.cpp:271 > - CGContextDrawImage(context, GraphicsContext(context).roundToDevicePixels(FloatRect(0, 0, CGImageGetWidth(image), CGImageGetHeight(image))), image); > + CGContextDrawImage(context, FloatRect(0, 0, CGImageGetWidth(image), CGImageGetHeight(image)), image); The change log says "This could only affect canvases at non-integral scale factors" but that doesn't seem to be true for this change. > Source/WebCore/platform/graphics/cg/PatternCG.cpp:43 > + CGRect rect = FloatRect(0, 0, CGImageGetWidth(platformImage), CGImageGetHeight(platformImage)); Ditto. Created attachment 92829 [details]
Patch
Committed r86085: <http://trac.webkit.org/changeset/86085> |