Summary: | update-webkit should handle Internal using a different VCS than OpenSource. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||
Component: | Tools / Tests | Assignee: | Andy Estes <aestes> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dbates | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Andy Estes
2011-05-05 16:18:56 PDT
Created attachment 92492 [details]
Patch
Comment on attachment 92492 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92492&action=review > Tools/ChangeLog:8 > + isGit() and isSVN() cache their results, so Internal will always be Are these methods used anywhere anymore? Maybe they can be removed? Comment on attachment 92492 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92492&action=review OK >> Tools/ChangeLog:8 >> + isGit() and isSVN() cache their results, so Internal will always be > > Are these methods used anywhere anymore? Maybe they can be removed? Yes, these functions are used in svn-apply and svn-unapply. (In reply to comment #2) > (From update of attachment 92492 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=92492&action=review > > > Tools/ChangeLog:8 > > + isGit() and isSVN() cache their results, so Internal will always be > > Are these methods used anywhere anymore? Maybe they can be removed? Yes, in svn-apply, svn-unapply and commit-log-editor. They could be removed and replaced with is(SVN|Git)Directory('.'), but that might slow down these commands if they make these checks repeatedly. This was committed in changeset 85898 <http://trac.webkit.org/changeset/85898>. |