Bug 60310 – update-webkit should handle Internal using a different VCS than OpenSource.

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Andy Estes]

update-webkit should handle Internal using a different VCS than OpenSource.

[Andy Estes]

Created attachment 92492 [details]
Patch

[Adam Barth]

Comment on attachment 92492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92492&action=review

> Tools/ChangeLog:8
> +        isGit() and isSVN() cache their results, so Internal will always be

Are these methods used anywhere anymore?  Maybe they can be removed?

[Daniel Bates]

Comment on attachment 92492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92492&action=review

OK

>> Tools/ChangeLog:8
>> +        isGit() and isSVN() cache their results, so Internal will always be
> 
> Are these methods used anywhere anymore?  Maybe they can be removed?

Yes, these functions are used in svn-apply and svn-unapply.

[Andy Estes]

(In reply to comment #2)
> (From update of attachment 92492 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=92492&action=review
> 
> > Tools/ChangeLog:8
> > +        isGit() and isSVN() cache their results, so Internal will always be
> 
> Are these methods used anywhere anymore?  Maybe they can be removed?

Yes, in svn-apply, svn-unapply and commit-log-editor. They could be removed and replaced with is(SVN|Git)Directory('.'), but that might slow down these commands if they make these checks repeatedly.

[Daniel Bates]

This was committed in changeset 85898 <http://trac.webkit.org/changeset/85898>.