Summary: | WebKit2: Docking Web Inspector doesn't respect maximum inspector size | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brian Weinstein <bweinstein> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Brian Weinstein <bweinstein> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, apavlov, aroben, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Brian Weinstein
2011-05-05 13:08:47 PDT
Created attachment 92455 [details]
[PATCH] Fix
Comment on attachment 92455 [details]
[PATCH] Fix
Why do we need to do this calculation in WebKit? Doens't WebCore already constrain the height for us?
Attachment 92455 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > (From update of attachment 92455 [details]) > Why do we need to do this calculation in WebKit? Doens't WebCore already constrain the height for us? WebCore doesn't constrain the height when initially attaching. It constrains the height when opening attached (which we don't do - due to <rdar://problem/9353114>), and it constrains when changing the attached window height. Doing the calculation in WebKit also allows us to handle resizing the inspector when the whole window is resized. http://trac.webkit.org/changeset/85874 might have broken GTK Linux 32-bit Debug The following tests are not passing: svg/W3C-SVG-1.1/animate-elem-46-t.svg |