Bug 60287

Summary: [chromium] switch from Lucida to free fonts for Hindi and Thai
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, bashi, evan, simonjam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch abarth: review+

Tony Chang
Reported 2011-05-05 12:13:24 PDT
[chromium] switch from Lucida to free fonts for Hindi and Thai
Attachments
Patch (987.64 KB, patch)
2011-05-05 12:17 PDT, Tony Chang 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2011-05-05 12:17:50 PDT
Created attachment 92442 [details] Patch
Tony Chang
Comment 2 2011-05-05 12:19:35 PDT
Adam, this change will require that you install ttf-thai-tlwg on your ews testing bot.
James Simonsen
Comment 3 2011-05-05 12:36:34 PDT
This will be nice! There are a couple of svg tests that explicitly call out lucida sans though. Do those still pass?
Tony Chang
Comment 4 2011-05-05 12:48:20 PDT
(In reply to comment #3) > This will be nice! > > There are a couple of svg tests that explicitly call out lucida sans though. Do those still pass? All the svg tests seem to pass for me with this change (hardy32 and lucid64). I'm not sure why; fontconfig is magic to me.
Adam Barth
Comment 5 2011-05-05 13:26:12 PDT
Comment on attachment 92442 [details] Patch I'm R+ing this patch out of pure excitement.
Tony Chang
Comment 6 2011-05-05 13:50:17 PDT
(In reply to comment #4) > (In reply to comment #3) > > There are a couple of svg tests that explicitly call out lucida sans though. Do those still pass? > > All the svg tests seem to pass for me with this change (hardy32 and lucid64). I'm not sure why; fontconfig is magic to me. grepping through the svg tests, I see LucidaSansUnicode, "Lucida Sans Unicode", Lucida Grande, and Lucida Console. None of these match Lucida Sans, so we weren't using Lucida in any of the svg tests.
Tony Chang
Comment 7 2011-05-05 14:26:45 PDT
Committed r85879: <http://trac.webkit.org/changeset/85879>
Note You need to log in before you can comment on or make changes to this bug.