Bug 60271

Summary: Web Inspector: move double click handling from TextEditor to SourceFrame.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch. pfeldman: review+

Pavel Podivilov
Reported 2011-05-05 08:44:45 PDT
It is SourceFrame's responsibility to check if content is editable and to configure TextEditor component (e.g. set editable range) when user tries to initiate editing.
Attachments
Patch. (9.27 KB, patch)
2011-05-05 08:48 PDT, Pavel Podivilov 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2011-05-05 08:48:23 PDT
Created attachment 92422 [details] Patch.
Pavel Podivilov
Comment 2 2011-05-05 08:49:12 PDT
Also renamed two delegate's methods: startEditing -> beforeTextChanged endEditing -> afterTextChanged
Pavel Podivilov
Comment 3 2011-05-16 03:15:39 PDT
Committed r86552: <http://trac.webkit.org/changeset/86552>
Note You need to log in before you can comment on or make changes to this bug.