Bug 60234

Summary: Rename SelectionController to FrameSelection
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Enhancement CC: ap, cmarcelo, darin, enrica, eric, gustavo.noronha, gustavo, justin.garcia, leviw, mjs, ojan, sam, tonikitoo, tony, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60228    
Attachments:
Description Flags
Renamed SelectionController to FrameSelection
none
Fixed gtk build eric: review+

Ryosuke Niwa
Reported 2011-05-04 17:56:19 PDT
SelectionController isn't really a controller in the sense that it contains a selection. It does have public member functions called by various parts of WebCore to update the selection state but it really is the selection of a frame, not a mere controller of the selection.
Attachments
Renamed SelectionController to FrameSelection (350.45 KB, patch)
2011-05-05 00:43 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed gtk build (351.77 KB, patch)
2011-05-05 09:40 PDT, Ryosuke Niwa 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-05-05 00:43:33 PDT
Created attachment 92383 [details] Renamed SelectionController to FrameSelection
Collabora GTK+ EWS bot
Comment 2 2011-05-05 07:22:08 PDT
Attachment 92383 [details] did not build on gtk: Build output: http://queues.webkit.org/results/8571435
Alexey Proskuryakov
Comment 3 2011-05-05 09:01:30 PDT
Do we ultimately want to make it PageSelection?
Ryosuke Niwa
Comment 4 2011-05-05 09:25:02 PDT
(In reply to comment #3) > Do we ultimately want to make it PageSelection? No. Selection must be maintained per frame and that's what the Web expects. As far as I can tell most of states in FrameSelection must persist independent of selection in other frames.
Ryosuke Niwa
Comment 5 2011-05-05 09:40:42 PDT
Created attachment 92427 [details] Fixed gtk build
Eric Seidel (no email)
Comment 6 2011-05-05 10:52:04 PDT
Comment on attachment 92427 [details] Fixed gtk build Assuming your just renaming things and you think you managed to get all 8 build systems right. :)
Ryosuke Niwa
Comment 7 2011-05-05 11:14:51 PDT
Committed r85864: <http://trac.webkit.org/changeset/85864>
Ryosuke Niwa
Comment 8 2011-05-05 11:20:26 PDT
Thanks for the review, Eric.
Note You need to log in before you can comment on or make changes to this bug.