Bug 60233 – sheriff-bot is having more exception trouble

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Adam Barth]

Updating working directory
Traceback (most recent call last):
  File "/mnt/git/webkit-sheriff-bot/Tools/Scripts/webkitpy/tool/bot/queueengine.py", line 96, in run
    work_item = self._delegate.next_work_item()
  File "/mnt/git/webkit-sheriff-bot/Tools/Scripts/webkitpy/tool/commands/sheriffbot.py", line 69, in next_work_item
    failure_map = self._tool.buildbot.failure_map()
  File "/mnt/git/webkit-sheriff-bot/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py", line 451, in failure_map
    regression_window = builder.find_blameworthy_regression_window(builder_status["build_number"])
  File "/mnt/git/webkit-sheriff-bot/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py", line 202, in find_blameworthy_regression_window
    red_build = self.build(red_build_number)
  File "/mnt/git/webkit-sheriff-bot/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py", line 93, in build
    build = self._fetch_build(build_number)
  File "/mnt/git/webkit-sheriff-bot/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py", line 82, in _fetch_build
    revision=int(build_dictionary['sourceStamp']['revision']),
TypeError: int() argument must be a string or a number, not 'NoneType'
Exception while preparing queue Sleeping until 2011-05-05 00:43:22 (2 mins).
Updating working directory

[Eric Seidel (no email)]

Created attachment 92358 [details]
Patch

[Adam Barth]

Comment on attachment 92358 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92358&action=review

> Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py:85
> +            # Buildbot uses any nubmer other than 0 to mean fail.  Since we fetch with

nubmer => number

[Eric Seidel (no email)]

Committed r85821: <http://trac.webkit.org/changeset/85821>