Bug 60222

Summary: Web Inspector: searching for node does not result in bringToFront call.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch yurys: review+, pfeldman: commit-queue+

Description Pavel Feldman 2011-05-04 15:48:26 PDT 
Patch to follow.
Comment 1 Pavel Feldman 2011-05-04 15:52:30 PDT 
Created attachment 92335 [details]
Patch
Comment 2 Yury Semikhatsky 2011-05-05 07:13:19 PDT 
Comment on attachment 92335 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92335&action=review

> Source/WebCore/inspector/InspectorDOMAgent.cpp:285
> +    m_inspectorFrontend = frontend->inspector();

InspectorDOMAgent is not supposed to access frontends other than DOMFrontend
Comment 3 Yury Semikhatsky 2011-05-05 07:14:02 PDT 
Comment on attachment 92335 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92335&action=review

> Source/WebCore/inspector/InspectorDOMAgent.cpp:889
> +        m_inspectorFrontend->bringToFront();

This should be handled on the front-end side.
Comment 4 Pavel Feldman 2011-05-05 07:25:34 PDT 
Created attachment 92414 [details]
Patch
Comment 5 Pavel Feldman 2011-05-05 09:38:45 PDT 
Committed r85858: <http://trac.webkit.org/changeset/85858>