Summary: | Windows build of WebKit GTK needs to be able to find SystemInfo.h | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fridrich Strba <fridrich.strba> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Windows XP | ||||||||
Attachments: |
|
Description
Fridrich Strba
2011-05-04 15:39:43 PDT
Created attachment 92332 [details]
Patch
Comment on attachment 92332 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92332&action=review Seems okay, but the ChangeLog format does not look correct. > Source/WebCore/ChangeLog:10 > + Add Source/WebCore/platform/win to teh paths searched > + for headers, since Source/WebCore/platform/win/SystemInfo.h > + header is needed by Source/WebKit/gtk/webkit/webkitwebsettings.cpp > + on Windows. > + https://bugs.webkit.org/show_bug.cgi?id=60221 > + teh -> the The ChangeLog format should be <bug title> <bug url> <description> > Source/WebCore/ChangeLog:11 > + No new tests. (OOPS!) You should remove this line or, even better, replace it with a short sentence saying why tests are not necessary. :) Created attachment 92336 [details]
Patch
Comment on attachment 92336 [details]
Patch
Modified changelog according to the review
Comment on attachment 92336 [details] Patch Clearing flags on attachment: 92336 Committed r85815: <http://trac.webkit.org/changeset/85815> All reviewed patches have been landed. Closing bug. |