| Summary: | SVG Filters do not support source images besides "sourceGraphic" and "sourceAlpha" | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||
| Component: | SVG | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | NEW --- | ||||||||
| Severity: | Normal | CC: | agomez, emacemac7, grebenshikov.n, ian, jeffschiller, jonlee, krit, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar, NeedsReduction, SVGHitList | ||||||
| Version: | 420+ | ||||||||
| Hardware: | Mac | ||||||||
| OS: | OS X 10.4 | ||||||||
| URL: | http://www.w3.org/TR/SVG/filters.html#CommonAttributes | ||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=150257 https://bugs.webkit.org/show_bug.cgi?id=150258 |
||||||||
| Bug Depends on: | 19835, 19991, 33320 | ||||||||
| Bug Blocks: | 68469, 26389 | ||||||||
| Attachments: |
|
||||||||
|
Description
Eric Seidel (no email)
2005-12-09 00:19:57 PST
Sorry, we already (clearly!) support <filter-primitive-reference>, just not the rest. None of these should be hard to do (with the possible exception of BackgroundImage/BackgroundAlpha. FillPaint and StrokePaint should probably be implemented as CIImages with ImageProviders, so they can lazily create the bits as needed. SourceAlpha is just SourceGraphic w/ an alpha-only filter applied. All of these should be lazily generated on demand. This is one of our two most basic SVG filter support bugs. Shipping SVG with filter support would require solving this bug. Adding SVGHitList keyword and bumping to p2. I've included instructions above on how we might implement these. Created attachment 6036 [details]
testcase showing a related bug
i've attached a reduced testcase showing a bug in the current sourcealpha support
Oh, those above numbers were using 5 runs each, cached content. We really need some test cases for these various modes. Created attachment 40584 [details]
Support for FilterEffect SourceAlpha
Support for FilterEffect SourceAlpha.
Comment on attachment 40584 [details]
Support for FilterEffect SourceAlpha
Looks great, r=me.
Comment on attachment 40584 [details] Support for FilterEffect SourceAlpha Clering review flag. Landed in r49153. Just adding a reference test, in case it is useful: https://rawgit.com/tanty/design-hodgepodge/master/svg/filter/feBlend-backgroundimage-tests.html Notice that for SVG 2 the "enable-background" is deprecated and the blending is governed by the isolation property: http://dev.w3.org/fxtf/compositing-1/#isolation Also, notice that, if I'm understanding correctly how the isolation property works, when using a SVG filter we shouldn't worry about what it is behind the SVG document since the filter makes a mandatory isolated group: https://drafts.fxtf.org/compositing-1/#csscompositingrules_SVG Similar issues from other web engines: https://bugzilla.mozilla.org/show_bug.cgi?id=437554 https://code.google.com/p/chromium/issues/detail?id=137230 https://wpdev.uservoice.com/forums/257854-microsoft-edge-developer/suggestions/10238658-implement-backgroundimage-backgroundalpha-input-so |