Bug 60207

Summary: Framebuffer object is being created twice
Product: WebKit Reporter: Igor Trindade Oliveira <igor.oliveira>
Component: WebGLAssignee: Igor Trindade Oliveira <igor.oliveira>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, commit-queue, igor.oliveira, kbr
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
kbr: review+, commit-queue: commit-queue-
Patch none

Igor Trindade Oliveira
Reported 2011-05-04 13:36:23 PDT
Mac, Qt and GTK implementation of DrawingBuffer class is creating the framebuffer object twice.
Attachments
Patch (3.68 KB, patch)
2011-05-04 13:39 PDT, Igor Trindade Oliveira 		kbr: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Patch (3.64 KB, patch)
2011-05-05 02:30 PDT, Igor Trindade Oliveira 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Igor Trindade Oliveira
Comment 1 2011-05-04 13:39:34 PDT
Created attachment 92311 [details] Patch Proposed patch
Kenneth Russell
Comment 2 2011-05-04 18:56:42 PDT
Comment on attachment 92311 [details] Patch Nice catch. Looks good.
WebKit Commit Bot
Comment 3 2011-05-04 20:26:12 PDT
Comment on attachment 92311 [details] Patch Rejecting attachment 92311 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'la..." exit_code: 2 Last 500 characters of output: d to run "[u'git', u'svn', u'dcommit']" exit_code: 1 cwd: /Projects/CommitQueue/ Updating OpenSource From git://git.webkit.org/WebKit d0efaae1..92959a5 master -> origin/master M Source/WebCore/WebCore.exp.in M Source/WebCore/ChangeLog M Source/WebCore/page/EventHandler.h M Source/WebCore/page/EventHandler.cpp r85826 = 92959a51805398e4546997e7287e03c1c3b262eb (refs/remotes/trunk) First, rewinding head to replay your work on top of it... Fast-forwarded new_master to refs/remotes/trunk. Full output: http://queues.webkit.org/results/8552793
Igor Trindade Oliveira
Comment 4 2011-05-05 02:30:26 PDT
Created attachment 92396 [details] Patch Trying again.
Kenneth Russell
Comment 5 2011-05-05 13:08:57 PDT
Comment on attachment 92396 [details] Patch OK.
WebKit Commit Bot
Comment 6 2011-05-05 15:10:13 PDT
Comment on attachment 92396 [details] Patch Clearing flags on attachment: 92396 Committed r85891: <http://trac.webkit.org/changeset/85891>
WebKit Commit Bot
Comment 7 2011-05-05 15:10:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.