Bug 60180

Summary: Including RenderLayerCompositor.h with USE(ACCELERATED_COMPOSITING) disabled causes compilation error.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: REOPENED ---    
Severity: Normal CC: simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.6   

Description Jer Noble 2011-05-04 09:41:15 PDT
RenderLayerCompositor inherits from GraphicsLayerClient, the definition of which is wrapped in a USE(ACCELERATED_COMPOSITING) conditional.  If RenderLayerCompositor is truly dependent on a class which is only available when that flag is enabled, the RenderLayerCompositor should be wrapped in a USE(ACCELERATED_COMPOSITING) conditional as well.
Comment 1 Simon Fraser (smfr) 2011-05-04 09:44:05 PDT
RenderLayerCompositor.h should be included within guards. That's what we do everywhere.

#include "RenderLayerCompositor.h"
Comment 2 Simon Fraser (smfr) 2011-05-04 09:54:18 PDT
Seems OK to wrap the header contents in guards.