Bug 60178
| Summary: | webkit-patch build-attachment doesn't build | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | abarth, eric |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
David Kilzer (:ddkilzer)
$ ./Tools/Scripts/webkit-patch build-attachment --build-style=release --no-clean --no-update 92252
Reading Keychain for bugs.webkit.org account and password. Click "Allow" to continue...
Logging in as ddkilzer@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=92252&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=59143&ctype=xml
Processing 1 patch from 1 bug.
Processing patch 92252 from bug 59143.
$
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
I believe you have to pass the --build flag these days. We should really fix that. :(
Adam Barth
The "build" command shows how to do that. build-attachment is a hidden command that's mostly just used internally.
David Kilzer (:ddkilzer)
(In reply to comment #2)
> The "build" command shows how to do that. build-attachment is a hidden command that's mostly just used internally.
I used "webkit-patch help --all" to find it. The synopsis didn't warn about it being "internal-only" or requiring a --build argument to work.
Eric Seidel (no email)
--all is a scary place! But yes, our documentation should be made much much better. :(
There was some discussion at the advanced tool usage session about labeling some commands as "internal" or "experimental" now that more people are looking at --all.