Bug 60173

Summary: [Chromium] Change the --accelerated-2d-canvas flag to mean Ganesh, and stop using --enable-accelerated-drawing for that purpose
Product: WebKit Reporter: Justin Novosad <junov>
Component: Layout and RenderingAssignee: Justin Novosad <junov>
Status: RESOLVED FIXED    
Severity: Normal CC: alokp, commit-queue, jamesr, kbr, senorblanco, vangelis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 60168    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Justin Novosad
Reported 2011-05-04 08:56:08 PDT
This is phase 2 of the delivery of the solution for https://bugs.webkit.org/show_bug.cgi?id=59929 This change will make the GPU accelerated 2D canvas lab use skia for rendering, which will likely require re-baselining several of the gpu layout test and also adding additional failures to test_expectaions.txt for the unresolved issues.
Attachments
Patch (10.71 KB, patch)
2011-05-05 13:00 PDT, Justin Novosad 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Justin Novosad
Comment 1 2011-05-05 10:24:11 PDT
Currently blocked on: http://code.google.com/p/chromium/issues/detail?id=81674
Justin Novosad
Comment 2 2011-05-05 13:00:50 PDT
Created attachment 92454 [details] Patch
Kenneth Russell
Comment 3 2011-05-05 14:42:37 PDT
Comment on attachment 92454 [details] Patch Thumbs up assuming it's been tested and won't turn the tree red. Please watch the canaries (see http://www.chromium.org/developers/how-tos/webkit-merge-1 ).
Justin Novosad
Comment 4 2011-05-05 14:53:35 PDT
(In reply to comment #3) > (From update of attachment 92454 [details]) > Thumbs up assuming it's been tested and won't turn the tree red. Please watch the canaries (see http://www.chromium.org/developers/how-tos/webkit-merge-1 ). The try-bots came back clear on all platforms.
James Robinson
Comment 5 2011-05-05 15:04:59 PDT
Did you run through the layout trybots (linux_layout, mac_layout, win_layout)?
James Robinson
Comment 6 2011-05-05 15:07:12 PDT
http://build.chromium.org/p/tryserver.chromium/builders/linux_layout/builds/638 shows a lot of crashes on canvas tests
Justin Novosad
Comment 7 2011-05-05 15:09:48 PDT
(In reply to comment #6) > http://build.chromium.org/p/tryserver.chromium/builders/linux_layout/builds/638 shows a lot of crashes on canvas tests No worries, that run did not have brian's fix in it. I launched a new try with --revision=84277. It came back clean on win_layout_rel. Still haven't heard back from the debug bot though
WebKit Commit Bot
Comment 8 2011-05-05 15:39:26 PDT
Comment on attachment 92454 [details] Patch Clearing flags on attachment: 92454 Committed r85895: <http://trac.webkit.org/changeset/85895>
WebKit Commit Bot
Comment 9 2011-05-05 15:39:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.