Bug 60164

Summary: REGRESSION (r85657): webkitpy.common.prettypatch_unittest.PrettyPatchTest.test_pretty_diff_encodings failing on Leopard
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Caio Marcelo de Oliveira Filho <cmarcelo>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue
Priority: P2 Keywords: PlatformOnly, Regression
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Adam Roben (:aroben)
Reported 2011-05-04 06:08:59 PDT
webkitpy.common.prettypatch_unittest.PrettyPatchTest.test_pretty_diff_encodings has been failing on Leopard since r85657. http://build.webkit.org/builders/Leopard%20Intel%20Release%20%28Tests%29/builds/31821 did not fail http://build.webkit.org/builders/Leopard%20Intel%20Release%20%28Tests%29/builds/31822 failed It is not failing on other versions of Mac OS X, or on Windows.
Attachments
Patch (1.31 KB, patch)
2011-05-04 06:56 PDT, Caio Marcelo de Oliveira Filho 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-05-04 06:19:38 PDT
From the bot: $ ruby --version ruby 1.8.6 (2009-06-08 patchlevel 369) [universal-darwin9.0]
Caio Marcelo de Oliveira Filho
Comment 2 2011-05-04 06:56:04 PDT
Created attachment 92233 [details] Patch
Eric Seidel (no email)
Comment 3 2011-05-04 07:03:46 PDT
Comment on attachment 92233 [details] Patch Rejecting attachment 92233 [details] from commit-queue. cmarcelo@webkit.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
WebKit Commit Bot
Comment 4 2011-05-04 07:55:53 PDT
Comment on attachment 92233 [details] Patch Clearing flags on attachment: 92233 Committed r85750: <http://trac.webkit.org/changeset/85750>
WebKit Commit Bot
Comment 5 2011-05-04 07:55:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.