Bug 60164 – REGRESSION (r85657): webkitpy.common.prettypatch_unittest.PrettyPatchTest.test_pretty_diff_encodings failing on Leopard

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adam Roben (:aroben)]

webkitpy.common.prettypatch_unittest.PrettyPatchTest.test_pretty_diff_encodings has been failing on Leopard since r85657.

http://build.webkit.org/builders/Leopard%20Intel%20Release%20%28Tests%29/builds/31821 did not fail
http://build.webkit.org/builders/Leopard%20Intel%20Release%20%28Tests%29/builds/31822 failed

It is not failing on other versions of Mac OS X, or on Windows.

[Adam Roben (:aroben)]

From the bot:

$ ruby --version
ruby 1.8.6 (2009-06-08 patchlevel 369) [universal-darwin9.0]

[Caio Marcelo de Oliveira Filho]

Created attachment 92233 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 92233 [details]
Patch

Rejecting attachment 92233 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 92233 [details]
Patch

Clearing flags on attachment: 92233

Committed r85750: <http://trac.webkit.org/changeset/85750>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.