Bug 60132

Summary: media/controls-css-overload.html is timing out on chromium bots
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: MediaAssignee: Steve Lacey <sjl>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, imasaki, scherkus, sjl, vrk, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Comment 1 imasaki 2011-05-06 11:21:20 PDT
This issue is tracked in
http://code.google.com/p/chromium/issues/detail?id=80771
Comment 2 Andrew Scherkus 2011-05-16 19:45:04 PDT
*** Bug 60941 has been marked as a duplicate of this bug. ***
Comment 3 Steve Lacey 2011-05-26 17:08:31 PDT
Created attachment 95083 [details]
Patch
Comment 4 Steve Lacey 2011-05-26 17:11:39 PDT
Created attachment 95084 [details]
Patch
Comment 5 Steve Lacey 2011-05-26 17:14:18 PDT
Seems like there's a problem layoutTestController tickled by the behaviour of media/controls-after-reload.html.

Fixed the test (as it's behaviour was a little odd) and will create a chromium side bug on DRT.
Comment 6 Eric Carlson 2011-05-26 19:22:57 PDT
Comment on attachment 95084 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95084&action=review

> LayoutTests/media/controls-after-reload.html:33
> +        video.src = findMediaFile("video", "content/test");
> +        video.load();

the video.load() is unnecessary and wasteful. load() used to be required after changing src, but the spec was changed so setting src triggers the load algorithm some time ago.
Comment 7 Steve Lacey 2011-05-26 19:38:08 PDT
Comment on attachment 95084 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95084&action=review

>> LayoutTests/media/controls-after-reload.html:33

> 
> the video.load() is unnecessary and wasteful. load() used to be required after changing src, but the spec was changed so setting src triggers the load algorithm some time ago.

Agreed. It was in the original code - I'll remove it, and the one in test().
Comment 8 Steve Lacey 2011-05-27 10:14:09 PDT
Created attachment 95187 [details]
Patch
Comment 9 Eric Carlson 2011-05-27 14:30:01 PDT
Comment on attachment 95187 [details]
Patch

Thanks Steve!
Comment 10 WebKit Commit Bot 2011-05-27 16:18:20 PDT
Comment on attachment 95187 [details]
Patch

Clearing flags on attachment: 95187

Committed r87583: <http://trac.webkit.org/changeset/87583>
Comment 11 WebKit Commit Bot 2011-05-27 16:18:25 PDT
All reviewed patches have been landed.  Closing bug.