Bug 60132

Summary: media/controls-css-overload.html is timing out on chromium bots
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: MediaAssignee: Steve Lacey <sjl>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, imasaki, scherkus, sjl, vrk, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Attachments
Patch (2.24 KB, patch)
2011-05-26 17:08 PDT, Steve Lacey 		no flags
DetailsFormatted DiffDiff
Patch (3.22 KB, patch)
2011-05-26 17:11 PDT, Steve Lacey 		no flags
DetailsFormatted DiffDiff
Patch (3.39 KB, patch)
2011-05-27 10:14 PDT, Steve Lacey 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
imasaki
Comment 1 2011-05-06 11:21:20 PDT
This issue is tracked in http://code.google.com/p/chromium/issues/detail?id=80771
Andrew Scherkus
Comment 2 2011-05-16 19:45:04 PDT
*** Bug 60941 has been marked as a duplicate of this bug. ***
Steve Lacey
Comment 3 2011-05-26 17:08:31 PDT
Created attachment 95083 [details] Patch
Steve Lacey
Comment 4 2011-05-26 17:11:39 PDT
Created attachment 95084 [details] Patch
Steve Lacey
Comment 5 2011-05-26 17:14:18 PDT
Seems like there's a problem layoutTestController tickled by the behaviour of media/controls-after-reload.html. Fixed the test (as it's behaviour was a little odd) and will create a chromium side bug on DRT.
Eric Carlson
Comment 6 2011-05-26 19:22:57 PDT
Comment on attachment 95084 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95084&action=review > LayoutTests/media/controls-after-reload.html:33 > + video.src = findMediaFile("video", "content/test"); > + video.load(); the video.load() is unnecessary and wasteful. load() used to be required after changing src, but the spec was changed so setting src triggers the load algorithm some time ago.
Steve Lacey
Comment 7 2011-05-26 19:38:08 PDT
Comment on attachment 95084 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95084&action=review >> LayoutTests/media/controls-after-reload.html:33 > > the video.load() is unnecessary and wasteful. load() used to be required after changing src, but the spec was changed so setting src triggers the load algorithm some time ago. Agreed. It was in the original code - I'll remove it, and the one in test().
Steve Lacey
Comment 8 2011-05-27 10:14:09 PDT
Created attachment 95187 [details] Patch
Eric Carlson
Comment 9 2011-05-27 14:30:01 PDT
Comment on attachment 95187 [details] Patch Thanks Steve!
WebKit Commit Bot
Comment 10 2011-05-27 16:18:20 PDT
Comment on attachment 95187 [details] Patch Clearing flags on attachment: 95187 Committed r87583: <http://trac.webkit.org/changeset/87583>
WebKit Commit Bot
Comment 11 2011-05-27 16:18:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.