Bug 60104

Summary:

[EFL] Fix build break after r85624

Product:

WebKit

Reporter:

Jaehun Lim <ljaehun.lim>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

gyuyoung.kim, lucas.de.marchi, ryuan.choi

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Proposed patch	none
Proposed patch	none

Jaehun Lim

Reported 2011-05-03 18:15:56 PDT

After removing '-P' build option in r85624, EFL build breaks. I think it makes some troubles for gcc < 4.6. (My gcc version is 4.4.3). First, I add '-P' again, but we need to find another way to remove '-P' option.

Attachments
Proposed patch (1.05 KB, patch) 2011-05-03 18:20 PDT, Jaehun Lim	no flags	Details Formatted Diff Diff
Proposed patch (1.05 KB, patch) 2011-05-03 18:25 PDT, Jaehun Lim	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jaehun Lim

Comment 1 2011-05-03 18:20:36 PDT

Created attachment 92180 [details] Proposed patch

Jaehun Lim

Comment 2 2011-05-03 18:25:48 PDT

Created attachment 92181 [details] Proposed patch

Lucas De Marchi

Comment 3 2011-05-03 19:34:51 PDT

(In reply to comment #0) > After removing '-P' build option in r85624, EFL build breaks. > I think it makes some troubles for gcc < 4.6. (My gcc version is 4.4.3). > First, I add '-P' again, but we need to find another way to remove '-P' option. What's the error message? For me it's broken with or without this patch, but with this patch it's a bit better

Ryuan Choi

Comment 4 2011-05-03 19:41:16 PDT

(In reply to comment #3) > (In reply to comment #0) > > After removing '-P' build option in r85624, EFL build breaks. > > I think it makes some troubles for gcc < 4.6. (My gcc version is 4.4.3). > > First, I add '-P' again, but we need to find another way to remove '-P' option. > > What's the error message? > > For me it's broken with or without this patch, but with this patch it's a bit better Below is messages. /workspace/webkit/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:66:66: error: no ‘JSC::JSValue WebCore::JSCanvasRenderingContext2D::strokeStyle(JSC::ExecState*) const’ member function declared in class ‘WebCore::JSCanvasRenderingContext2D’ /workspace/webkit/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:72:79: error: no ‘void WebCore::JSCanvasRenderingContext2D::setStrokeStyle(JSC::ExecState*, JSC::JSValue)’ member function declared in class ‘WebCore::JSCanvasRenderingContext2D’ /workspace/webkit/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:82:64: error: no ‘JSC::JSValue WebCore::JSCanvasRenderingContext2D::fillStyle(JSC::ExecState*) const’ member function declared in class ‘WebCore::JSCanvasRenderingContext2D’ /workspace/webkit/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:88:77: error: no ‘void WebCore::JSCanvasRenderingContext2D::setFillStyle(JSC::ExecState*, JSC::JSValue)’ member function declared in class ‘WebCore::JSCanvasRenderingContext2D’ /workspace/webkit/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:98:65: error: no ‘JSC::JSValue WebCore::JSCanvasRenderingContext2D::setFillColor(JSC::ExecState*)’ member function declared in class ‘WebCore::JSCanvasRenderingContext2D’ BTW, does we need to add --preprocessor ? Although removed, it looks fine.

Lucas De Marchi

Comment 5 2011-05-03 19:52:45 PDT

(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #0) > > > After removing '-P' build option in r85624, EFL build breaks. > > > I think it makes some troubles for gcc < 4.6. (My gcc version is 4.4.3). > > > First, I add '-P' again, but we need to find another way to remove '-P' option. > > > > What's the error message? > > > > For me it's broken with or without this patch, but with this patch it's a bit better > > Below is messages. > > /workspace/webkit/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:66:66: error: no ‘JSC::JSValue WebCore::JSCanvasRenderingContext2D::strokeStyle(JSC::ExecState*) const’ member function declared in class ‘WebCore::JSCanvasRenderingContext2D’ > /workspace/webkit/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:72:79: error: no ‘void WebCore::JSCanvasRenderingContext2D::setStrokeStyle(JSC::ExecState*, JSC::JSValue)’ member function declared in class ‘WebCore::JSCanvasRenderingContext2D’ > /workspace/webkit/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:82:64: error: no ‘JSC::JSValue WebCore::JSCanvasRenderingContext2D::fillStyle(JSC::ExecState*) const’ member function declared in class ‘WebCore::JSCanvasRenderingContext2D’ > /workspace/webkit/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:88:77: error: no ‘void WebCore::JSCanvasRenderingContext2D::setFillStyle(JSC::ExecState*, JSC::JSValue)’ member function declared in class ‘WebCore::JSCanvasRenderingContext2D’ > /workspace/webkit/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:98:65: error: no ‘JSC::JSValue WebCore::JSCanvasRenderingContext2D::setFillColor(JSC::ExecState*)’ member function declared in class ‘WebCore::JSCanvasRenderingContext2D’ > > BTW, does we need to add --preprocessor ? > Although removed, it looks fine. Humn... i think this is the problem. Maybe removing the --preprocessor will do the job for all versions

Gyuyoung Kim

Comment 6 2011-05-03 20:02:22 PDT

Comment on attachment 92181 [details] Proposed patch Lucas is going to land this patch directly.

Note You need to log in before you can comment on or make changes to this bug.