Summary: | WK2 Icon Database should provide access to all image representations in the icon. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit.review.bot | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Brady Eidson
2011-05-03 17:07:49 PDT
Created attachment 92174 [details]
Patch v1
Attachment 92174 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/cg/ImageCG.cpp:177: Use 0 instead of NULL. [readability/null] [5]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 92174 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=92174&action=review > Source/WebCore/platform/graphics/BitmapImage.h:145 > + virtual RetainPtr<CFArrayRef> getCGImageArray(); I am not sure if get here is necessary, since you are returning a RetainPtr. |