Bug 60087 - WK2 Icon Database should provide access to all image representations in the icon.
Summary: WK2 Icon Database should provide access to all image representations in the i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-05-03 17:07 PDT by Brady Eidson
Modified: 2011-05-03 17:39 PDT (History)
1 user (show)

See Also:

Attachments
Patch v1 (5.59 KB, patch)
2011-05-03 17:13 PDT, Brady Eidson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2011-05-03 17:07:49 PDT 
WK2 Icon Database should provide access to all image representations in the icon.

We need this for the CG platforms.

In radar as <rdar://problem/9373182>
Comment 1 Brady Eidson 2011-05-03 17:13:18 PDT 
Created attachment 92174 [details]
Patch v1
Comment 2 WebKit Review Bot 2011-05-03 17:14:30 PDT 
Attachment 92174 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/graphics/cg/ImageCG.cpp:177:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2011-05-03 17:24:31 PDT 
Comment on attachment 92174 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=92174&action=review

> Source/WebCore/platform/graphics/BitmapImage.h:145
> +    virtual RetainPtr<CFArrayRef> getCGImageArray();

I am not sure if get here is necessary, since you are returning a RetainPtr.
Comment 4 Brady Eidson 2011-05-03 17:39:07 PDT 
Landed in r85697