Bug 60080

Summary: Split createLineBoxesFromBidiRuns out from layoutRunsAndFloats
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, leviw, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 36921    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description Eric Seidel (no email) 2011-05-03 16:20:13 PDT 
Split createLineBoxesFromBidiRuns out from layoutRunsAndFloats
Comment 1 Eric Seidel (no email) 2011-05-03 16:24:08 PDT 
Created attachment 92161 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-05-03 16:29:00 PDT 
Created attachment 92163 [details]
Patch
Comment 3 Ryosuke Niwa 2011-05-03 16:58:58 PDT 
Comment on attachment 92163 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92163&action=review

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:930
> +            if (bidiRuns.runCount() && hyphenated)
> +                bidiRuns.logicallyLastRun()->m_hasHyphen = true;
> +
>              BidiRun* trailingSpaceRun = !lineInfo.previousLineBrokeCleanly() ? handleTrailingSpaces(bidiRuns, resolver.context()) : 0;

Are you certain that handleTrailingSpaces won't be affected by assigning the value to m_hasHyphen earlier?
Comment 4 Eric Seidel (no email) 2011-05-03 17:01:40 PDT 
Created attachment 92172 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2011-05-04 04:49:53 PDT 
The commit-queue encountered the following flaky tests while processing attachment 92172 [details]:

http/tests/inspector/console-websocket-error.html bug 57392 (authors: pfeldman@chromium.org and yutak@chromium.org)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2011-05-04 04:51:19 PDT 
Comment on attachment 92172 [details]
Patch for landing

Clearing flags on attachment: 92172

Committed r85732: <http://trac.webkit.org/changeset/85732>
Comment 7 WebKit Commit Bot 2011-05-04 04:51:25 PDT 
All reviewed patches have been landed.  Closing bug.