Bug 60049

Summary: [Qt] Fix signals emitted in FakeReply used in autotests
Product: WebKit Reporter: Caio Marcelo de Oliveira Filho <cmarcelo>
Component: New BugsAssignee: Caio Marcelo de Oliveira Filho <cmarcelo>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Description Caio Marcelo de Oliveira Filho 2011-05-03 12:25:20 PDT
[Qt] Fix signals emitted in FakeReply used in autotests
Comment 1 Caio Marcelo de Oliveira Filho 2011-05-03 12:36:03 PDT
Created attachment 92105 [details]
Patch
Comment 2 Luiz Agostini 2011-05-03 13:06:04 PDT
Comment on attachment 92105 [details]
Patch

LGTM
Comment 3 Benjamin Poulain 2011-05-04 11:30:36 PDT
Comment on attachment 92105 [details]
Patch

make sense
Comment 4 WebKit Commit Bot 2011-05-04 12:00:55 PDT
Comment on attachment 92105 [details]
Patch

Clearing flags on attachment: 92105

Committed r85772: <http://trac.webkit.org/changeset/85772>
Comment 5 WebKit Commit Bot 2011-05-04 12:01:00 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2011-05-04 15:07:37 PDT
http://trac.webkit.org/changeset/85772 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
http/tests/navigation/response204.html
Comment 7 Caio Marcelo de Oliveira Filho 2011-05-04 15:50:01 PDT
(In reply to comment #6)
> http://trac.webkit.org/changeset/85772 might have broken GTK Linux 64-bit Debug
> The following tests are not passing:
> http/tests/navigation/response204.html

For the record: this patch only affects Qt autotests (small C++ programs that we use to test Qt API). So it's a "false alarm".

PS: I'm not sure if it's helpful to add this kind of follow up.