| Summary: | store results.html options in localstorage | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ojan Vafai <ojan> | ||||
| Component: | New Bugs | Assignee: | Ojan Vafai <ojan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eric, mihaip, tony | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Ojan Vafai
2011-05-03 11:49:56 PDT
Created attachment 92098 [details]
Patch
Comment on attachment 92098 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92098&action=review > LayoutTests/fast/harness/resources/results-test.js:65 > +function runTest(results, assertions, opt_localStorageValue) opt_? Funny prefix. (In reply to comment #2) > (From update of attachment 92098 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=92098&action=review > > > LayoutTests/fast/harness/resources/results-test.js:65 > > +function runTest(results, assertions, opt_localStorageValue) > > opt_? Funny prefix. It's a convention I picked up from Google's JS code. I'm happy to remove the prefix or do something different. It's useful to be able to specify that an argument is optional though. Comment on attachment 92098 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92098&action=review >>> LayoutTests/fast/harness/resources/results-test.js:65 >> >> opt_? Funny prefix. > > It's a convention I picked up from Google's JS code. I'm happy to remove the prefix or do something different. It's useful to be able to specify that an argument is optional though. The opt_ prefix seems fine considering we already checked in some code for it. We can discuss/change if we decide to have a JS style guide. Committed r85654: <http://trac.webkit.org/changeset/85654> |