Bug 60041

Summary: [CMAKE] Remove C++0x compat mode warnings for GCC >= 4.6.0
Product: WebKit Reporter: Lucas De Marchi <lucas.de.marchi>
Component: New BugsAssignee: Lucas De Marchi <lucas.de.marchi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kenneth, lucas.de.marchi, mrobinson, tonikitoo, xan.lopez, yang.jie
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Lucas De Marchi
Reported 2011-05-03 11:01:25 PDT
[CMAKE] Remove C++0x compat mode warnings for GCC >= 4.6.0
Attachments
Patch (1.68 KB, patch)
2011-05-03 11:03 PDT, Lucas De Marchi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Lucas De Marchi
Comment 1 2011-05-03 11:03:48 PDT
Created attachment 92091 [details] Patch
Xan Lopez
Comment 2 2011-05-03 11:14:18 PDT
Comment on attachment 92091 [details] Patch Looks good to me!
Lucas De Marchi
Comment 3 2011-05-03 20:16:01 PDT
Comment on attachment 92091 [details] Patch Clearing flags on attachment: 92091 Committed r85710: <http://trac.webkit.org/changeset/85710>
Lucas De Marchi
Comment 4 2011-05-03 20:16:23 PDT
All reviewed patches have been landed. Closing bug.
Keyon
Comment 5 2011-07-14 02:16:04 PDT
why the patch is only added to Source/cmake/WebKitHelpers.cmake? I found the compling still failed on the 14.0.812.0 chromium, log as below:   CXX(target) out/Release/obj.target/webcore_bindings/gen/webkit/bindings/V8DerivedSources01.o In file included from third_party/WebKit/Source/JavaScriptCore/wtf/PassRefPtr.h:25:0,                  from third_party/WebKit/Source/JavaScriptCore/wtf/CrossThreadRefCounted.h:35,                  from third_party/WebKit/Source/JavaScriptCore/wtf/text/StringImpl.h:28,                  from third_party/WebKit/Source/JavaScriptCore/wtf/text/WTFString.h:28,                  from third_party/WebKit/Source/WebCore/platform/text/PlatformString.h:28,                  from third_party/WebKit/Source/WebCore/loader/cache/CachedResource.h:28,                  from third_party/WebKit/Source/WebCore/loader/cache/CachedResourceHandle.h:29,                  from third_party/WebKit/Source/WebCore/dom/Clipboard.h:27,                  from third_party/WebKit/Source/WebCore/dom/Event.h:27,                  from third_party/WebKit/Source/WebCore/dom/BeforeProcessEvent.h:30,                  from out/Release/obj/gen/webkit/bindings/V8BeforeProcessEvent.h:24,                  from out/Release/obj/gen/webcore/bindings/V8BeforeProcessEvent.cpp:22,                  from out/Release/obj/gen/webkit/bindings/V8DerivedSources01.cpp:31: third_party/WebKit/Source/JavaScriptCore/wtf/NullPtr.h:48:1: error:  identifier 'nullptr' will become a keyword in C++0x  [-Werror=c++0x-compat] this patch is already there.
Note You need to log in before you can comment on or make changes to this bug.