Bug 60011

Summary:

Remove redundant conversion from auto table layout to auto table layout in CSSStyleSelector::applyProperty()

Product:

WebKit

Reporter:

Luke Macpherson <macpherson>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, eric, macpherson

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none

Description Luke Macpherson 2011-05-03 00:00:34 PDT

Remove redundant conversion from auto table layout to auto table layout in CSSStyleSelector::applyProperty()

Comment 1 Luke Macpherson 2011-05-03 00:01:59 PDT

Created attachment 92051 [details]
Patch

Comment 2 Luke Macpherson 2011-05-03 00:03:18 PDT

Removed code is analogous to if (x==y) x = y;

Comment 3 Darin Adler 2011-05-03 11:02:05 PDT

Comment on attachment 92051 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92051&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

Can’t land this as is. You need to replace this line with an explanation of why this change doesn’t require new tests.

Comment 4 Luke Macpherson 2011-05-03 16:55:02 PDT

Created attachment 92169 [details]
Patch

Comment 5 Luke Macpherson 2011-05-03 16:56:39 PDT

Fixed ChangeLog entry.

Comment 6 Eric Seidel (no email) 2011-05-04 01:11:39 PDT

Comment on attachment 92169 [details]
Patch

This code is obviously very old. :)

Comment 7 WebKit Commit Bot 2011-05-04 04:35:55 PDT

Comment on attachment 92169 [details]
Patch

Clearing flags on attachment: 92169

Committed r85730: <http://trac.webkit.org/changeset/85730>

Comment 8 WebKit Commit Bot 2011-05-04 04:36:00 PDT

All reviewed patches have been landed.  Closing bug.