Bug 59985

Summary: nrwt: revamp integration tests incl. tests for servers
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Severity: Normal CC: abarth, aroben, eric, ojan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 59977    
Bug Blocks:    
Description Flags
add mock_drt_unittest changes ojan: review+

Description Dirk Pranke 2011-05-02 17:10:28 PDT
nrwt: revamp integration tests incl. tests for servers
Comment 1 Dirk Pranke 2011-05-02 17:19:51 PDT
Created attachment 92014 [details]
Comment 2 Dirk Pranke 2011-05-02 18:06:21 PDT
Created attachment 92022 [details]
add mock_drt_unittest changes
Comment 3 Dirk Pranke 2011-05-02 18:12:00 PDT
Note that this patch has three main aspects:

(1) it adds real tests for the http and websocket servers - relevant given the fix in bug 59977

(2) it gives us a way to run "integration" tests that will affect the environment on the local machine (as opposed to unit tests). I added some functions to port_testcase.py for this, but it needs a better home.

And (3) it adds a default set of integration tests to each port implementation via the port_testcase.py module.
Comment 4 Adam Barth 2011-05-02 18:14:10 PDT
Comment on attachment 92022 [details]
add mock_drt_unittest changes

View in context: https://bugs.webkit.org/attachment.cgi?id=92022&action=review

> Tools/ChangeLog:12
> +        These tests can be run manually by invoking python on the
> +        test file in question and passing the '-i' flag, but are
> +        not run automatically as part of test-webkitpy.

Comment 5 Dirk Pranke 2011-05-05 15:42:41 PDT
Committed r85896: <http://trac.webkit.org/changeset/85896>