Bug 59978

Summary: add image toggling behavior from old-run-webkit-tests
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: arv, dpranke, eric, mihai, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch tony: review+

Description Ojan Vafai 2011-05-02 16:56:03 PDT
add image toggling behavior from old-run-webkit-tests
Comment 1 Ojan Vafai 2011-05-02 16:59:55 PDT
Created attachment 92006 [details]
Patch
Comment 2 Tony Chang 2011-05-02 17:32:08 PDT
Comment on attachment 92006 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92006&action=review

> LayoutTests/fast/harness/resources/results-test.js:114
> +{    

Nit: trailing whitespace

> Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:251
> +""" % (self._testname, self.output_filename('-diff.png'), self.output_filename(''))
> +        self._port._filesystem.write_binary_file(diffs_html_filename, html)

Nit: When I have lots of replacement params, I normally switch to the named placeholders.
Comment 3 Ojan Vafai 2011-05-03 09:30:52 PDT
Committed r85610: <http://trac.webkit.org/changeset/85610>