Bug 59963

Summary: fix failing printing_unittest on win32
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, eric, ojan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch abarth: review+, abarth: commit-queue-

Description Dirk Pranke 2011-05-02 14:34:15 PDT
fix failing printing_unittest on win32
Comment 1 Dirk Pranke 2011-05-02 14:34:57 PDT
Created attachment 91982 [details]
Patch
Comment 2 Adam Barth 2011-05-02 18:11:40 PDT
Comment on attachment 91982 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91982&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:588
> -        # FIXME: scm.py outputs debug logging to stderr. It should probably go to stdout.
> -        self.assertFalse(err.empty())
> +        # FIXME: debug output from the port and scm objects may or may not go
> +        # to stderr, so there's no point in testing its contents here.
> +        # self.assertTrue(err.empty())

Generally we don't want commented out code.  Maybe just remove it?
Comment 3 Dirk Pranke 2011-05-02 18:17:04 PDT
Sure, I can do that.
Comment 4 Dirk Pranke 2011-05-03 14:14:57 PDT
Committed r85658: <http://trac.webkit.org/changeset/85658>