Bug 59959

Summary: Handle DispatchOnConnectionQueue for asynchronous messages
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch aroben: review+

Anders Carlsson
Reported 2011-05-02 13:51:23 PDT
Handle DispatchOnConnectionQueue for asynchronous messages
Attachments
Patch (7.80 KB, patch)
2011-05-02 13:54 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (8.11 KB, patch)
2011-05-02 14:04 PDT, Anders Carlsson 		aroben: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-05-02 13:54:35 PDT
Created attachment 91975 [details] Patch
Adam Roben (:aroben)
Comment 2 2011-05-02 13:58:49 PDT
Comment on attachment 91975 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91975&action=review > Source/WebKit2/ChangeLog:11 > + * Scripts/webkit2/messages.py: Some function-level comments here would be nice. > Source/WebKit2/Scripts/webkit2/messages.py:84 > - match = re.search(r'([A-Za-z_0-9]+)\((.*?)\)(?:(?:\s+->\s+)\((.*?)\)(?:\s+(.*))?)?', line) > + match = re.search(r'([A-Za-z_0-9]+)\((.*?)\)(?:(?:\s+->\s+)\((.*?)\))?(?:\s+(.*))?', line) Please explain this change in the ChangeLog. > Source/WebKit2/Scripts/webkit2/messages.py:578 > + sync_dispatch_on_connection_queue_messages = [] Why don't we do anything with this list? I think this is why the GetPlugins and TestMultipleAttributes messages disappeared from the expected output.
Anders Carlsson
Comment 3 2011-05-02 14:03:44 PDT
(In reply to comment #2) > (From update of attachment 91975 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=91975&action=review > > > Source/WebKit2/ChangeLog:11 > > + * Scripts/webkit2/messages.py: > > Some function-level comments here would be nice. Done. > > > Source/WebKit2/Scripts/webkit2/messages.py:84 > > - match = re.search(r'([A-Za-z_0-9]+)\((.*?)\)(?:(?:\s+->\s+)\((.*?)\)(?:\s+(.*))?)?', line) > > + match = re.search(r'([A-Za-z_0-9]+)\((.*?)\)(?:(?:\s+->\s+)\((.*?)\))?(?:\s+(.*))?', line) > > Please explain this change in the ChangeLog. Done. > > > Source/WebKit2/Scripts/webkit2/messages.py:578 > > + sync_dispatch_on_connection_queue_messages = [] > > Why don't we do anything with this list? I think this is why the GetPlugins and TestMultipleAttributes messages disappeared from the expected output. Yup. We don't handle synchronous messages with the DispatchOnConnectionQueue attribute. I'm not sure if we actually need that.
Anders Carlsson
Comment 4 2011-05-02 14:04:05 PDT
Created attachment 91978 [details] Patch
Anders Carlsson
Comment 5 2011-05-02 14:05:02 PDT
Committed r85519: <http://trac.webkit.org/changeset/85519>
Note You need to log in before you can comment on or make changes to this bug.