Bug 59957

Summary: Prune #includes from FrameView.h (Part 1)
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch andersca: review+

Sam Weinig
Reported 2011-05-02 13:30:14 PDT
Prune #includes from FrameView.h (Part 1)
Attachments
Patch (2.03 KB, patch)
2011-05-02 13:31 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (3.32 KB, patch)
2011-05-02 14:03 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (3.90 KB, patch)
2011-05-02 14:19 PDT, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-05-02 13:31:07 PDT
Created attachment 91968 [details] Patch
WebKit Review Bot
Comment 2 2011-05-02 13:44:03 PDT
Attachment 91968 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8526825
Sam Weinig
Comment 3 2011-05-02 14:03:31 PDT
Created attachment 91977 [details] Patch
WebKit Review Bot
Comment 4 2011-05-02 14:06:29 PDT
Attachment 91977 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/Scrollbar.cpp:37: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 5 2011-05-02 14:11:14 PDT
Attachment 91977 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8529793
Sam Weinig
Comment 6 2011-05-02 14:19:14 PDT
Created attachment 91979 [details] Patch
WebKit Review Bot
Comment 7 2011-05-02 14:20:21 PDT
Attachment 91979 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/Scrollbar.cpp:37: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 8 2011-05-02 15:25:09 PDT
Attachment 91979 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8526853
WebKit Review Bot
Comment 9 2011-05-02 15:57:39 PDT
Attachment 91979 [details] did not pass chromium-ews: Output: http://queues.webkit.org/results/8534172
Build Bot
Comment 10 2011-05-02 22:18:18 PDT
Attachment 91979 [details] did not build on win: Build output: http://queues.webkit.org/results/8530871
Sam Weinig
Comment 11 2011-05-03 10:13:30 PDT
Landed in r85615.
Note You need to log in before you can comment on or make changes to this bug.