Web Inspector: revision history storage is too slow.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Pavel Feldman]

It turns out that iterating localStorage keys is very expensive (results in slow inspector start), refactor revision history in order not to rely upon that operation.

[Pavel Feldman]

Created attachment 91929 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 91929 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91929&action=review

> Source/WebCore/inspector/front-end/Resource.js:140
> +            if (resource && historyItem.loaderId === resource.loaderId) {

Can we make sure there is no collision between loaderIds?

> Source/WebCore/inspector/front-end/ResourceTreeModel.js:71
>          WebInspector.mainResource = this._addFramesRecursively(mainFramePayload);

Let's remove this: 
if (error)
6868            return;

[Pavel Feldman]

(In reply to comment #2)
> (From update of attachment 91929 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=91929&action=review
> 
> > Source/WebCore/inspector/front-end/Resource.js:140
> > +            if (resource && historyItem.loaderId === resource.loaderId) {
> 
> Can we make sure there is no collision between loaderIds?
> 

We don't have unique session id yet.

> > Source/WebCore/inspector/front-end/ResourceTreeModel.js:71
> >          WebInspector.mainResource = this._addFramesRecursively(mainFramePayload);
> 
> Let's remove this: 
> if (error)
> 6868            return;

I'll put console.error here.

[Pavel Feldman]

Committed r85591: <http://trac.webkit.org/changeset/85591>