Bug 59933

Summary: Port Mozilla's IndexedDB tests: cursor mutation in object store
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dgrogan, fishd, hans, pilgrim, tony
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Mark Pilgrim (Google)
Reported 2011-05-02 06:36:40 PDT
Original test: http://mxr.mozilla.org/mozilla2.0/source/dom/indexedDB/test/test_cursor_mutation.html?raw=1 This is a test case *adapted* from a test in Mozilla's IndexedDB test suite. The original test checked cursor mutation while iterating an index cursor (tracked as bug 59822). This test checks whether the cursor mutation is successfully recognized while iterating a straight objectstore cursor. Specifically, it deletes a record that's already been iterated, then adds a record to the objectstore during iteration, then checks that no records were skipped and that the added record is eventually found during iteration. WebKit passes this test.
Attachments
Patch (10.66 KB, patch)
2011-05-02 06:39 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (11.47 KB, patch)
2011-05-02 13:51 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2011-05-02 06:39:43 PDT
Created attachment 91921 [details] Patch
Tony Chang
Comment 2 2011-05-02 12:16:51 PDT
Comment on attachment 91921 [details] Patch Can you include the adaptations mentioned in comment 0 in the ChangeLog or in the test desctipion()?
Mark Pilgrim (Google)
Comment 3 2011-05-02 13:51:27 PDT
Created attachment 91974 [details] Patch
Mark Pilgrim (Google)
Comment 4 2011-05-02 13:52:29 PDT
Updated test description and ChangeLog.
WebKit Commit Bot
Comment 5 2011-05-02 16:51:17 PDT
Comment on attachment 91974 [details] Patch Clearing flags on attachment: 91974 Committed r85553: <http://trac.webkit.org/changeset/85553>
WebKit Commit Bot
Comment 6 2011-05-02 16:51:22 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 7 2011-05-02 18:58:54 PDT
The commit-queue encountered the following flaky tests while processing attachment 91974 [details]: http/tests/xmlhttprequest/cross-origin-no-authorization.html bug 33357 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
Note You need to log in before you can comment on or make changes to this bug.