Bug 59907

Summary: Prune some #includes from DOMWindow.h
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch abarth: review+

Sam Weinig
Reported 2011-05-01 18:15:39 PDT
Prune some #includes from DOMWindow.h
Attachments
Patch (12.67 KB, patch)
2011-05-01 18:21 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (13.56 KB, patch)
2011-05-01 22:08 PDT, Sam Weinig 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-05-01 18:21:41 PDT
Created attachment 91867 [details] Patch
Adam Barth
Comment 2 2011-05-01 18:23:43 PDT
Comment on attachment 91867 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91867&action=review > Source/WebCore/page/DOMWindow.h:98 > - void setSecurityOrigin(SecurityOrigin* securityOrigin) { m_securityOrigin = securityOrigin; } > + void setSecurityOrigin(SecurityOrigin*); You promised to remove this function a lot time ago!
Sam Weinig
Comment 3 2011-05-01 18:25:03 PDT
> You promised to remove this function a lot time ago! If only you could feel my guilt.
WebKit Review Bot
Comment 4 2011-05-01 18:28:48 PDT
Attachment 91867 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8525755
Early Warning System Bot
Comment 5 2011-05-01 18:35:30 PDT
Attachment 91867 [details] did not build on qt: Build output: http://queues.webkit.org/results/8531500
WebKit Review Bot
Comment 6 2011-05-01 20:18:58 PDT
Attachment 91867 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8526596
Sam Weinig
Comment 7 2011-05-01 22:08:35 PDT
Created attachment 91880 [details] Patch
Adam Barth
Comment 8 2011-05-01 22:12:11 PDT
Comment on attachment 91880 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91880&action=review I support this product and/or service. > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) OOPS!
Sam Weinig
Comment 9 2011-05-02 10:35:17 PDT
Committed r85484: <http://trac.webkit.org/changeset/85484>
Note You need to log in before you can comment on or make changes to this bug.