Summary: | Prune some #includes from DOMWindow.h | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dglazkov, webkit-ews, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Sam Weinig
2011-05-01 18:15:39 PDT
Created attachment 91867 [details]
Patch
Comment on attachment 91867 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91867&action=review > Source/WebCore/page/DOMWindow.h:98 > - void setSecurityOrigin(SecurityOrigin* securityOrigin) { m_securityOrigin = securityOrigin; } > + void setSecurityOrigin(SecurityOrigin*); You promised to remove this function a lot time ago! > You promised to remove this function a lot time ago!
If only you could feel my guilt.
Attachment 91867 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8525755 Attachment 91867 [details] did not build on qt: Build output: http://queues.webkit.org/results/8531500 Attachment 91867 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8526596 Created attachment 91880 [details]
Patch
Comment on attachment 91880 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91880&action=review I support this product and/or service. > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) OOPS! Committed r85484: <http://trac.webkit.org/changeset/85484> |