| Summary: | Web Inspector: combine status bar button glyphs. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit-ews, webkit.review.bot, yurys | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Pavel Feldman
2011-05-01 13:06:52 PDT
Created attachment 91836 [details]
Patch
Attachment 91836 [details] did not build on qt: Build output: http://queues.webkit.org/results/8523818 Attachment 91836 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8530419 Created attachment 91837 [details]
Patch
Cool, I've always thought this would be a good idea. It makes adding a new image slightly more difficult, but it has a number of nice improvements (reducing separate requests [great for remote], all images show at once, smaller total size). Any reason why you stopped at 10 per line? Now there is a line with 9 "blanks" and causes the file size to be larger than it needs to be. Attachment 91837 [details] did not build on qt: Build output: http://queues.webkit.org/results/8521979 Attachment 91837 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8521984 Created attachment 91913 [details]
Patch
(In reply to comment #5) > Cool, I've always thought this would be a good idea. It makes adding a > new image slightly more difficult, but it has a number of nice > improvements (reducing separate requests [great for remote], all images > show at once, smaller total size). > This is great not only for remote. > Any reason why you stopped at 10 per line? Now there is a line with > 9 "blanks" and causes the file size to be larger than it needs to be. Yeah, it is easier to reference the image that way (using row and column with 10 items per row). I don't think we care about few extra bytes for that. Comment on attachment 91913 [details] Patch Clearing flags on attachment: 91913 Committed r85587: <http://trac.webkit.org/changeset/85587> All reviewed patches have been landed. Closing bug. |