Bug 59882

Summary: webkit-patch fails when not run from root
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Severity: Normal CC: andersca, dpranke, eric, mihaip, mjs, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Description Flags
Patch eric: review+, abarth: commit-queue+

Description Adam Barth 2011-05-01 11:51:18 PDT
webkit-patch fails when not run from root
Comment 1 Adam Barth 2011-05-01 11:52:18 PDT
Created attachment 91830 [details]
Comment 2 Eric Seidel (no email) 2011-05-01 11:54:18 PDT
Comment on attachment 91830 [details]

I'm confused.  I thought that SVN didn't run all commands relative to the root to support maciej's fancy -d thing.
Comment 3 Adam Barth 2011-05-01 11:55:47 PDT
scm.py always interprets file paths relative to the root of the working copy.  The -d option restricts the scope of our "stat" commands to restrict which parts of the working copy we operate upon.
Comment 4 Adam Barth 2011-05-01 11:58:13 PDT
Committed r85424: <http://trac.webkit.org/changeset/85424>
Comment 5 Eric Seidel (no email) 2011-05-01 12:00:57 PDT
Letting other python hackers see this go by, to hopefully end any confusion here.