Bug 59882

Summary: webkit-patch fails when not run from root
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, dpranke, eric, mihaip, mjs, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch eric: review+, abarth: commit-queue+

Adam Barth
Reported 2011-05-01 11:51:18 PDT
webkit-patch fails when not run from root
Attachments
Patch (1.20 KB, patch)
2011-05-01 11:52 PDT, Adam Barth 		eric: review+
abarth: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-05-01 11:52:18 PDT
Created attachment 91830 [details] Patch
Eric Seidel (no email)
Comment 2 2011-05-01 11:54:18 PDT
Comment on attachment 91830 [details] Patch I'm confused. I thought that SVN didn't run all commands relative to the root to support maciej's fancy -d thing.
Adam Barth
Comment 3 2011-05-01 11:55:47 PDT
scm.py always interprets file paths relative to the root of the working copy. The -d option restricts the scope of our "stat" commands to restrict which parts of the working copy we operate upon.
Adam Barth
Comment 4 2011-05-01 11:58:13 PDT
Committed r85424: <http://trac.webkit.org/changeset/85424>
Eric Seidel (no email)
Comment 5 2011-05-01 12:00:57 PDT
Letting other python hackers see this go by, to hopefully end any confusion here.
Note You need to log in before you can comment on or make changes to this bug.